EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/305606
Change subject: Appropriatly check KafkaHandler requireAck argument
......................................................................
Appropriatly check KafkaHandler requireAck argument
This requireAck argument was supposed to allow enabling turning
on or off the requirement to get ackowledgment of log messages
being written to kafka. Due to a minor mistake though, it was
always enabled regardless of the configuration. Fix that.
Change-Id: I08cb9839a5a93bc586904a1a66ec6c9b05a97707
---
M includes/debug/logger/monolog/KafkaHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/06/305606/1
diff --git a/includes/debug/logger/monolog/KafkaHandler.php
b/includes/debug/logger/monolog/KafkaHandler.php
index 432a9e1..a15560d 100644
--- a/includes/debug/logger/monolog/KafkaHandler.php
+++ b/includes/debug/logger/monolog/KafkaHandler.php
@@ -120,7 +120,7 @@
$options['logExceptions'] = LoggerFactory::getInstance(
$options['logExceptions'] );
}
- if ( isset( $options['requireAck'] ) ) {
+ if ( isset( $options['requireAck'] ) && $options['requireAck']
) {
$produce->setRequireAck( $options['requireAck'] );
}
--
To view, visit https://gerrit.wikimedia.org/r/305606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08cb9839a5a93bc586904a1a66ec6c9b05a97707
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
