Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/301437
Change subject: AuthManager: Don't display wpRemember if it doesn't have any
effect
......................................................................
AuthManager: Don't display wpRemember if it doesn't have any effect
If $wgExtendedLoginCookieExpiration is set to null, clicking the
wpRemember checkbox on the login form has no effect, so it shouldn't
be visible at all. This change makes the checkbox dependent on the
config option.
Bug: T141478
Change-Id: I500e4761c4e19400fd4faa920ed2706e00861e79
---
M includes/auth/AuthManager.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/37/301437/1
diff --git a/includes/auth/AuthManager.php b/includes/auth/AuthManager.php
index 82eeff0..b831a5d 100644
--- a/includes/auth/AuthManager.php
+++ b/includes/auth/AuthManager.php
@@ -2064,7 +2064,9 @@
// AuthManager has its own req for some actions
switch ( $providerAction ) {
case self::ACTION_LOGIN:
- $reqs[] = new RememberMeAuthenticationRequest;
+ if ( (int)$this->config->get(
'ExtendedLoginCookieExpiration' ) > 0 ) {
+ $reqs[] = new
RememberMeAuthenticationRequest;
+ }
break;
case self::ACTION_CREATE:
--
To view, visit https://gerrit.wikimedia.org/r/301437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I500e4761c4e19400fd4faa920ed2706e00861e79
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
