Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357584 )
Change subject: Check that function hook is callable whe4n registering.
......................................................................
Check that function hook is callable whe4n registering.
This is to dafeguard against issues like T167238.
In general, type checks should be applied when things get
registered for later use. Fail early, stay sane.
Change-Id: Ifb7005ee214829c98cec534261c0db7d13f50f35
---
M includes/parser/Parser.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/84/357584/1
diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 34f6232..bba8702 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -22,6 +22,7 @@
*/
use MediaWiki\Linker\LinkRenderer;
use MediaWiki\MediaWikiServices;
+use Wikimedia\Assert\Assert;
use Wikimedia\ScopedCallback;
/**
@@ -4858,6 +4859,8 @@
public function setFunctionHook( $id, $callback, $flags = 0 ) {
global $wgContLang;
+ Assert::parameterType( 'callable', $callback, '$callback' );
+
$oldVal = isset( $this->mFunctionHooks[$id] ) ?
$this->mFunctionHooks[$id][0] : null;
$this->mFunctionHooks[$id] = [ $callback, $flags ];
--
To view, visit https://gerrit.wikimedia.org/r/357584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb7005ee214829c98cec534261c0db7d13f50f35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
