Sbisson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/345854 )
Change subject: RC Filters: Handle conflict.item === {}
......................................................................
RC Filters: Handle conflict.item === {}
In some cases, conflict.item is an empty
object instead of an instance of FilterItem.
This came up during the testing of the wikidata
conflict patch.
I did not investigate the cause so this might not
be the right fix for it.
Change-Id: I58bccf21b81515e766e4df0776792dbb50050211
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/345854/1
diff --git a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
index 221d2a5..88a95dd 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterItem.js
@@ -131,7 +131,7 @@
key = key || 'contextDescription';
$.each( conflicts, function ( filterName, conflict ) {
- if ( !conflict.item.isSelected() ) {
+ if ( !( conflict.item && conflict.item.isSelected() ) )
{
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/345854
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58bccf21b81515e766e4df0776792dbb50050211
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
