Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/310572
Change subject: Remove all browser tests ...................................................................... Remove all browser tests There broken and not needed now. Change-Id: I7c76bd0825e8cb2cfa251327f0d2c4f634a54eef --- D tests/browser/features/aftv5.feature D tests/browser/features/step_definitions/aftv5_steps.rb D tests/browser/features/support/env.rb D tests/browser/features/support/pages/aftv5_page.rb 4 files changed, 0 insertions(+), 190 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 refs/changes/72/310572/1 diff --git a/tests/browser/features/aftv5.feature b/tests/browser/features/aftv5.feature deleted file mode 100644 index 3ad7e50..0000000 --- a/tests/browser/features/aftv5.feature +++ /dev/null @@ -1,36 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -# See http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Platforms for internet_explorer_6 -@chrome @firefox @internet_explorer_7 @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @phantomjs -Feature: AFTv5 - - Background: - Given I am at an AFTv5 page - - Scenario: Check if AFTv5 is on the page - Then AFTv5 should be there - - Scenario: Click Yes return and click No - When I click Yes and No - Then I can always return to AFTv5 input - - Scenario: Check Whats this with Learn more - When I click Whats this - Then I see a floating text window with Learn more link - - Scenario: Click yes and see feedback guide and terms - When I click Yes - Then I see helpful feedback guide and terms - - Scenario: Click yes and leave feedback - When I click Yes - Then I can enter and save text diff --git a/tests/browser/features/step_definitions/aftv5_steps.rb b/tests/browser/features/step_definitions/aftv5_steps.rb deleted file mode 100644 index b5b3c32..0000000 --- a/tests/browser/features/step_definitions/aftv5_steps.rb +++ /dev/null @@ -1,103 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -Given(/^I am at an AFTv5 page$/) do - visit AFTv5Page -end - -When(/^I click Whats this$/) do - on(AFTv5Page) do |page| - page.whats_this_element.when_present.click - end -end -When(/^I click Yes$/) do - on(AFTv5Page) do |page| - page.yes_element.when_present.click - end -end -When(/^I click Yes and No$/) do - on(AFTv5Page) do |page| - page.yes_element.exists? - page.yes_element.when_present.click - page.back_to_yesno - page.no_element.when_present.click - page.back_to_yesno - end -end - -Then(/^AFTv5 should be there$/) do - on(AFTv5Page) do |page| - page.yes_element.when_present.should be_visible - page.no_element.when_present.should be_visible - page.whats_this_element.when_present.should be_visible - end -end -Then(/^After saving I have links to feedback page and See all comments available$/) do - on(AFTv5Page) do |page| - page.feedback_page_element.when_present.click - page.all_comments_element.should be_true - end -end -Then(/^Comments are shown Relevant and All and Sort By$/) do - on(AFTv5Page) do |page| - page.most_relevant.should be_true - page.sort_by_element.should be_true - end -end -Then(/^I can always return to AFTv5 input$/) do - on(AFTv5Page) do |page| - page.yes_element.should be_true - page.no_element.should be_true - end -end -Then(/^I can enter and save text$/) do - on(AFTv5Page) do |page| - @input_string = "Automated test did this #{('a' .. 'z').to_a.shuffle[0, 10].join}" - page.input_area_element.send_keys "Hello from #{@input_string}" - page.post_feedback_element.when_present.click - page.wait_until(10) do - page.text.include? "Thanks!" - end - page.text.should include "Your post can be viewed on this feedback page." - # ONLY ANONS GET "CREATE ACCOUNT"/LOG IN MESSAGE - page.create_account_element.should be_true - page.log_in_element.should be_true - end -end -Then(/^I have links to Learn more and View Article$/) do - on(AFTv5Page) do |page| - page.learn_more_element.should be_true - page.view_article_element.should be_true - end -end -Then(/^I see a floating text window with Learn more link$/) do - on(AFTv5Page) do |page| - page.text.should include "Wikipedia would like to hear what you think of this article. Share your feedback with the editors -- and help improve this page" - page.learn_more_element.should be_true - end -end -Then(/^I see helpful feedback guide and terms$/) do - on(AFTv5Page) do |page| - page.helpful_feedback_element.should be_true - page.terms_element.should be_true - end -end -Then(/^When I click to navigate to comments page my saved comment appears$/) do - on(AFTv5Page) do |page| - page.wait_until(10) do - page.all_comments_element.visible? - end - page.all_comments_element.when_present.click - page.wait_until(10) do - page.text.include? @input_string - end - end -end diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb deleted file mode 100644 index 515ff78..0000000 --- a/tests/browser/features/support/env.rb +++ /dev/null @@ -1,12 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -require "mediawiki_selenium" diff --git a/tests/browser/features/support/pages/aftv5_page.rb b/tests/browser/features/support/pages/aftv5_page.rb deleted file mode 100644 index de57316..0000000 --- a/tests/browser/features/support/pages/aftv5_page.rb +++ /dev/null @@ -1,39 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -require "page-object" - -# AFTv5 page object -class AFTv5Page - include PageObject - - include URL - page_url URL.url("Aftpage") - - div(:aft_box, id: "mw-articlefeedbackv5") - a(:all_comments, text: /All comments/) - a(:back_to_yesno, text: "Back to step 1") - span(:create_account, text: "Create an account") - a(:edit, text: "Edit source") - a(:feedback_page, text: "feedback page") - a(:helpful_feedback, href: "http://en.wikipedia.org/wiki/Wikipedia:Feedback_guidelines";, text: "helpful feedback") - text_area(:input_area, id: "articleFeedbackv5-find-feedback") - a(:learn_more, text: /Learn more/) - a(:log_in, text: "Log in") - a(:most_relevant, text: /Most relevant/) - span(:no, text: "No") - span(:post_feedback, text: "Post your feedback") - select(:sort_by, id: "articleFeedbackv5-sort-select") - a(:terms, href: "//wikimediafoundation.org/wiki/Feedback_privacy_statement", text: "terms") - a(:view_article, text: "View article") - a(:whats_this, text: "What's this?") - span(:yes, text: "Yes") -end -- To view, visit https://gerrit.wikimedia.org/r/310572 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c76bd0825e8cb2cfa251327f0d2c4f634a54eef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
