Harej has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/336053 )

Change subject: Slight button re-styling
......................................................................

Slight button re-styling

Making section edit/view buttons framed; Otherwise, it's hard to differentiate 
them from the content.

Also making the bottom buttons non-primary to avoid theme clashes. Also adding 
icons.

Change-Id: I7ea8558e8c45790613e2605905244a1bd28ad115
---
M includes/content/CollaborationHubContent.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit 
refs/changes/53/336053/1

diff --git a/includes/content/CollaborationHubContent.php 
b/includes/content/CollaborationHubContent.php
index 7564871..dc8ae17 100644
--- a/includes/content/CollaborationHubContent.php
+++ b/includes/content/CollaborationHubContent.php
@@ -448,14 +448,16 @@
                        $html .= new OOUI\ButtonWidget( [
                                'label' => wfMessage( 
'collaborationkit-hub-manage' )->inContentLanguage()->text(),
                                'href' => $title->getLocalURL( [ 'action' => 
'edit' ] ),
-                               'flags' => [ 'primary', 'progressive' ]
+                               'flags' => [ 'progressive' ],
+                               'icon' => 'edit'
                        ] );
 
                        // TODO make sure they have create permission, too
                        $html .= new OOUI\ButtonWidget( [
                                'label' => wfMessage( 
'collaborationkit-hub-addpage' )->inContentLanguage()->text(),
                                'href' => SpecialPage::getTitleFor( 
'CreateHubFeature' )->getFullUrl( [ 'collaborationhub' => $title->getFullText() 
] ),
-                               'flags' => [ 'primary', 'progressive' ]
+                               'flags' => [ 'progressive' ],
+                               'icon' => 'add'
                        ] );
                }
 
@@ -642,7 +644,7 @@
                $html = new OOUI\ButtonWidget( [
                        'label' => $message,
                        'href' => $link,
-                       'framed' => false,
+                       'framed' => true,
                        'icon' => $icon
                        ] );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/336053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ea8558e8c45790613e2605905244a1bd28ad115
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to