jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/334752 )
Change subject: Move description from extension.json to message file
......................................................................
Move description from extension.json to message file
Added i18n files and banana check
Change-Id: I60c12065a9cd90d57b5238dde7d1826efa84a119
---
A .gitignore
A Gruntfile.js
A i18n/en.json
A i18n/qqq.json
A package.json
M skin.json
6 files changed, 47 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Siebrand: Looks good to me, approved
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..7e5da87
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+node_modules/
+vendor/
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..472f993
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,20 @@
+/*jshint node:true */
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+ grunt.loadNpmTasks( 'grunt-banana-checker' );
+
+ var conf = grunt.file.readJSON( 'skin.json' );
+ grunt.initConfig( {
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**',
+ '!vendor/**'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/i18n/en.json b/i18n/en.json
new file mode 100644
index 0000000..0d06a40
--- /dev/null
+++ b/i18n/en.json
@@ -0,0 +1,4 @@
+{
+ "@metadata": {},
+ "dusk-desc": "Dusk MediaWiki skin, based on WordPress Dusk theme"
+}
diff --git a/i18n/qqq.json b/i18n/qqq.json
new file mode 100644
index 0000000..9b0e145
--- /dev/null
+++ b/i18n/qqq.json
@@ -0,0 +1,4 @@
+{
+ "@metadata": {},
+ "dusk-desc":
"{{desc|what=skin|name=Dusk|url=https://www.mediawiki.org/wiki/Skin:Dusk}}";
+}
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..bcf5b13
--- /dev/null
+++ b/package.json
@@ -0,0 +1,11 @@
+{
+ "private": true,
+ "scripts": {
+ "test": "grunt test"
+ },
+ "devDependencies": {
+ "grunt": "1.0.1",
+ "grunt-banana-checker": "0.5.0",
+ "grunt-jsonlint": "1.1.0"
+ }
+}
diff --git a/skin.json b/skin.json
index 9dfb995..79085e4 100644
--- a/skin.json
+++ b/skin.json
@@ -7,12 +7,17 @@
"Jack Phoenix"
],
"url": "https://www.mediawiki.org/wiki/Skin:Dusk";,
- "description": "Dusk MediaWiki skin, based on WordPress Dusk theme",
+ "descriptionmsg": "dusk-desc",
"license-name": "GPL-2.0+",
"type": "skin",
"ValidSkinNames": {
"dusk": "Dusk"
},
+ "MessagesDirs": {
+ "SkinDusk": [
+ "i18n"
+ ]
+ },
"AutoloadClasses": {
"SkinDusk": "Dusk.skin.php",
"DuskTemplate": "Dusk.skin.php"
--
To view, visit https://gerrit.wikimedia.org/r/334752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60c12065a9cd90d57b5238dde7d1826efa84a119
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/Dusk
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Raimond Spekking <raimond.spekk...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
