Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/307023
Change subject: Change 'unwatch' icon to an empty star
......................................................................
Change 'unwatch' icon to an empty star
Bug: T132975
Change-Id: I1dbd6d1480f6ef5a45184271c932cd27258f7424
---
M includes/formatters/EventPresentationModel.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/23/307023/1
diff --git a/includes/formatters/EventPresentationModel.php
b/includes/formatters/EventPresentationModel.php
index 0b4b44a..a9228d0 100644
--- a/includes/formatters/EventPresentationModel.php
+++ b/includes/formatters/EventPresentationModel.php
@@ -655,7 +655,12 @@
return $this->getDynamicActionLink(
$title,
- $isTitleWatched ? 'unStar' : 'star',
+ // Design requirements are to flip the star icons
+ // in their meaning; that is, for the 'unwatch' action
+ // we should display an empty star, and for the 'watch'
+ // action a full star. In OOUI icons, their names
+ // are reversed.
+ $isTitleWatched ? 'star' : 'unStar',
$data,
array( 'action' => $availableAction )
);
--
To view, visit https://gerrit.wikimedia.org/r/307023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dbd6d1480f6ef5a45184271c932cd27258f7424
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
