Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387639 )
Change subject: Hygiene: Minerva explicitly defines placeholderMsg for
SearchOverlay
......................................................................
Hygiene: Minerva explicitly defines placeholderMsg for SearchOverlay
Currently the SearchOverlay inside MobileFrontend uses global jQuery
to get this. Minerva should provide this information instead.
Change-Id: I50e7341d1f19af495e79ae20860ff4071bda12a0
---
M resources/skins.minerva.scripts/search.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/39/387639/1
diff --git a/resources/skins.minerva.scripts/search.js
b/resources/skins.minerva.scripts/search.js
index 2f188b1..8dcb157 100644
--- a/resources/skins.minerva.scripts/search.js
+++ b/resources/skins.minerva.scripts/search.js
@@ -22,6 +22,7 @@
// see https://phabricator.wikimedia.org/T156508#2977463
overlay = new SearchOverlay( {
router: router,
+ placeholderMsg: $( '#searchInput' ).attr( 'placeholder'
),
gatewayClass: SearchGateway,
api: new mw.Api(),
searchTerm: searchTerm,
--
To view, visit https://gerrit.wikimedia.org/r/387639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50e7341d1f19af495e79ae20860ff4071bda12a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
