Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335176 )
Change subject: Define header height in pixels ...................................................................... Define header height in pixels When expressed in ems due to how browsers round up decimals the height can differ leading to inconsistencies. Bug: T156509 Change-Id: I77f74acc089d7606f648da2eeb6153214f6a0b08 --- M resources/skins.minerva.base.styles/ui.less 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/76/335176/1 diff --git a/resources/skins.minerva.base.styles/ui.less b/resources/skins.minerva.base.styles/ui.less index 06d6c06..06a7f80 100644 --- a/resources/skins.minerva.base.styles/ui.less +++ b/resources/skins.minerva.base.styles/ui.less @@ -89,16 +89,19 @@ } } +.banner-container { + // When banners are present we want to easily distinguish between them and the header so add border + border-bottom: 1px solid @colorGray12; + margin-top: @headerMarginTop; +} + .header { display: table; width: 100%; border-spacing: 0; border-collapse: collapse; - height: @headerHeight; + height: floor(unit(@headerHeight*16, px)); white-space: nowrap; - // When banners are present we want to easily distinguish between them and the header so add border - border-top: 1px solid @colorGray12; - margin-top: @headerMarginTop; // button > div { -- To view, visit https://gerrit.wikimedia.org/r/335176 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77f74acc089d7606f648da2eeb6153214f6a0b08 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: branding Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits