Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315427
Change subject: All View's can now call toHtmlString
......................................................................
All View's can now call toHtmlString
Change-Id: I92272d65bebdbcda407f98713be26ee712d233c1
---
M resources/mobile.startup/Icon.js
M resources/mobile.view/View.js
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/27/315427/1
diff --git a/resources/mobile.startup/Icon.js b/resources/mobile.startup/Icon.js
index afee83b..b72f2e2 100644
--- a/resources/mobile.startup/Icon.js
+++ b/resources/mobile.startup/Icon.js
@@ -59,14 +59,6 @@
getGlyphClassName: function () {
return this.options.base + '-' + this.options.name;
},
- /**
- * Return the HTML representation of this view
- * @method
- * @return {String}
- */
- toHtmlString: function () {
- return $( '<div>' ).append( this.$el ).html();
- },
template: mw.template.get( 'mobile.startup', 'icon.hogan' )
} );
diff --git a/resources/mobile.view/View.js b/resources/mobile.view/View.js
index 197f65d..bf38f37 100644
--- a/resources/mobile.view/View.js
+++ b/resources/mobile.view/View.js
@@ -322,6 +322,16 @@
},
/**
+ * Return the HTML representation of this view
+ * FIXME: See https://phabricator.wikimedia.org/T129943
+ * @method
+ * @return {String}
+ */
+ toHtmlString: function () {
+ return $( '<div>' ).append( this.$el ).html();
+ },
+
+ /**
* A finer-grained `undelegateEvents` for removing a single
delegated event.
* `selector` and `listener` are both optional.
*
--
To view, visit https://gerrit.wikimedia.org/r/315427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92272d65bebdbcda407f98713be26ee712d233c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
