Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348007 )
Change subject: Tweaks for printing layout
......................................................................
Tweaks for printing layout
* Use @page to override print margins in Chrome and force legal size
* Limit desktop auto margin rules to the screen media type. In print
mode this can cause rendering issues - for example the footer that is
printed is incomplete. This seems to be due to the auto margin rules.
Given in print mode we have a fixed canvas this should not be necessary
Bug: T159857
Change-Id: Ia4d619ce6dd0e96580bca389867aad4a10c924d6
---
M resources/mobile.languages.structured/LanguageOverlay.less
M resources/skins.minerva.print.styles/styles.less
M resources/skins.minerva.tablet.styles/common.less
3 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/07/348007/1
diff --git a/resources/mobile.languages.structured/LanguageOverlay.less
b/resources/mobile.languages.structured/LanguageOverlay.less
index 641f8cd..5639979 100644
--- a/resources/mobile.languages.structured/LanguageOverlay.less
+++ b/resources/mobile.languages.structured/LanguageOverlay.less
@@ -80,7 +80,7 @@
}
}
-@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media screen and ( min-width: @wgMFDeviceWidthDesktop ) {
.language-overlay {
.overlay-content {
margin: 0;
diff --git a/resources/skins.minerva.print.styles/styles.less
b/resources/skins.minerva.print.styles/styles.less
index 8b60513..134d424 100644
--- a/resources/skins.minerva.print.styles/styles.less
+++ b/resources/skins.minerva.print.styles/styles.less
@@ -1,4 +1,16 @@
@media print {
+ // Chrome: override the default margins and reveal the footer
+ // Experimental technology (see
https://developer.mozilla.org/en-US/docs/Web/CSS/@page/size)
+ @page {
+ size: legal;
+ margin: 0;
+ padding: 0;
+ }
+
+ html {
+ padding: 0 50px;
+ }
+
@import 'header.less';
@import 'article.less';
@import 'blockquotes.less';
diff --git a/resources/skins.minerva.tablet.styles/common.less
b/resources/skins.minerva.tablet.styles/common.less
index 113ac78..2f4fefa 100644
--- a/resources/skins.minerva.tablet.styles/common.less
+++ b/resources/skins.minerva.tablet.styles/common.less
@@ -135,7 +135,7 @@
}
}
-@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
+@media screen and ( min-width: @wgMFDeviceWidthDesktop ) {
// FIXME: Zero should use banner-container class or better - append to
banner-container
#mw-mf-page-center .mw-mf-banner,
.banner-container,
--
To view, visit https://gerrit.wikimedia.org/r/348007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4d619ce6dd0e96580bca389867aad4a10c924d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
