jenkins-bot has submitted this change and it was merged.

Change subject: Hid category links in source edit mode
......................................................................


Hid category links in source edit mode

Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
---
M modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
M modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
3 files changed, 10 insertions(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css 
b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
index 0f00305..a5566f9 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.DesktopArticleTarget.css
@@ -40,6 +40,10 @@
        text-decoration: none;
 }
 
+.ve-init-mw-articleTarget-source .catlinks {
+       display: none;
+}
+
 /*!
  * Increase z-index of surface container so it appears above the debug bar
  */
diff --git 
a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
index 19ab5b4..b93a893 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopWikitextArticleTarget.js
@@ -16,9 +16,6 @@
 ve.init.mw.DesktopWikitextArticleTarget = function 
VeInitMwDesktopWikitextArticleTarget( config ) {
        // Parent constructor
        ve.init.mw.DesktopWikitextArticleTarget.super.call( this, config );
-
-       // Initialization
-       this.$element.addClass( 've-init-mw-desktopWikitextArticleTarget' );
 };
 
 /* Inheritance */
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js 
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 3ffbf51..545dba5 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -194,6 +194,12 @@
  */
 ve.init.mw.ArticleTarget.prototype.setMode = function ( mode ) {
        if ( mode !== this.mode ) {
+               // The follow classes are used here:
+               // * ve-init-mw-articleTarget-visual
+               // * ve-init-mw-articleTarget-source
+               this.$element
+                       .removeClass( 've-init-mw-articleTarget-' + this.mode )
+                       .addClass( 've-init-mw-articleTarget-' + mode );
                this.mode = mode;
                this.updateTabs( true );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/314745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib44e393d3a8d070a4ced002a11cb26f58447e67c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to