jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/368552 )
Change subject: Use strict comparison in SpecialNewEntity::isListed ...................................................................... Use strict comparison in SpecialNewEntity::isListed Previous bool cast caused 0 (zero) to be interpreted as false. Bug: T169456 Change-Id: I9581bdd20dd8c1a8f4ea3cca33dad7feac79e918 --- M repo/includes/Specials/SpecialNewEntity.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ladsgroup: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/Specials/SpecialNewEntity.php b/repo/includes/Specials/SpecialNewEntity.php index 86a193d..ed93d41 100644 --- a/repo/includes/Specials/SpecialNewEntity.php +++ b/repo/includes/Specials/SpecialNewEntity.php @@ -75,7 +75,7 @@ * @see SpecialPage::isListed() */ public function isListed() { - return (bool)$this->entityNamespaceLookup->getEntityNamespace( $this->getEntityType() ); + return $this->entityNamespaceLookup->getEntityNamespace( $this->getEntityType() ) !== null; } /** -- To view, visit https://gerrit.wikimedia.org/r/368552 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9581bdd20dd8c1a8f4ea3cca33dad7feac79e918 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits