WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/350540 )
Change subject: Adjust the contructor of SpecialNewLexeme
......................................................................
Adjust the contructor of SpecialNewLexeme
Parent class constructor has been changed
in Ieeeb3740d32b9c5de2f00a56197d5ff6efc63aa3.
Change-Id: I7a93b0d767bd989c544cb284a38a8c8ff7add780
---
M src/Specials/SpecialNewLexeme.php
M tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
2 files changed, 35 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/40/350540/1
diff --git a/src/Specials/SpecialNewLexeme.php
b/src/Specials/SpecialNewLexeme.php
index e6b8170..a316e03 100644
--- a/src/Specials/SpecialNewLexeme.php
+++ b/src/Specials/SpecialNewLexeme.php
@@ -9,9 +9,11 @@
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Term\Term;
use Wikibase\DataModel\Term\TermList;
+use Wikibase\EditEntityFactory;
use Wikibase\Lexeme\DataModel\Lexeme;
use Wikibase\Lib\Store\EntityNamespaceLookup;
use Wikibase\Lexeme\Specials\HTMLForm\LanguageLookupWidgetField;
+use Wikibase\Lib\Store\EntityTitleLookup;
use Wikibase\Repo\Specials\HTMLForm\HTMLContentLanguageField;
use Wikibase\Repo\Specials\HTMLForm\HTMLItemReferenceField;
use Wikibase\Repo\Specials\HTMLForm\HTMLTrimmedTextField;
@@ -19,6 +21,7 @@
use Wikibase\Repo\WikibaseRepo;
use Wikibase\Repo\Specials\SpecialPageCopyrightView;
use Wikibase\Summary;
+use Wikibase\SummaryFormatter;
/**
* Page for creating new Lexeme entities.
@@ -45,14 +48,31 @@
$settings->getSetting( 'dataRightsText' )
);
- return new self( $copyrightView,
$wikibaseRepo->getEntityNamespaceLookup() );
+ return new self(
+ $copyrightView,
+ $wikibaseRepo->getEntityNamespaceLookup(),
+ $wikibaseRepo->getSummaryFormatter(),
+ $wikibaseRepo->getEntityTitleLookup(),
+ $wikibaseRepo->newEditEntityFactory()
+ );
}
public function __construct(
SpecialPageCopyrightView $copyrightView,
- EntityNamespaceLookup $entityNamespaceLookup
+ EntityNamespaceLookup $entityNamespaceLookup,
+ SummaryFormatter $summaryFormatter,
+ EntityTitleLookup $entityTitleLookup,
+ EditEntityFactory $editEntityFactory
) {
- parent::__construct( 'NewLexeme', 'createpage', $copyrightView,
$entityNamespaceLookup );
+ parent::__construct(
+ 'NewLexeme',
+ 'createpage',
+ $copyrightView,
+ $entityNamespaceLookup,
+ $summaryFormatter,
+ $entityTitleLookup,
+ $editEntityFactory
+ );
}
/**
diff --git a/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
b/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
index b323067..ce99809 100644
--- a/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
+++ b/tests/phpunit/mediawiki/Specials/SpecialNewLexemeTest.php
@@ -13,6 +13,7 @@
use Wikibase\Lib\Store\EntityNamespaceLookup;
use Wikibase\Repo\Tests\Specials\SpecialNewEntityTest;
use Wikibase\Repo\WikibaseRepo;
+use Wikibase\SummaryFormatter;
/**
* @covers Wikibase\Lexeme\Specials\SpecialNewLexeme
@@ -30,9 +31,19 @@
protected function newSpecialPage() {
$irrelevantNamespaceNumber = -1;
+ $wikibaseRepo = WikibaseRepo::getDefaultInstance();
+
+ /** @var SummaryFormatter $summaryFormatter */
+ $summaryFormatter = $this->getMockBuilder(
SummaryFormatter::class )
+ ->disableOriginalConstructor()
+ ->getMock();
+
return new SpecialNewLexeme(
$this->copyrightView,
- new EntityNamespaceLookup( [ Lexeme::ENTITY_TYPE =>
$irrelevantNamespaceNumber ] )
+ new EntityNamespaceLookup( [ Lexeme::ENTITY_TYPE =>
$irrelevantNamespaceNumber ] ),
+ $summaryFormatter,
+ $wikibaseRepo->getEntityTitleLookup(),
+ $wikibaseRepo->newEditEntityFactory()
);
}
--
To view, visit https://gerrit.wikimedia.org/r/350540
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a93b0d767bd989c544cb284a38a8c8ff7add780
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
