BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390546 )
Change subject: Update node-rdkafka dependency to 2.x ...................................................................... Update node-rdkafka dependency to 2.x Breaking Changes mentioned for 2.0.0 release[1] 1. Keys are now returned as buffers in delivery reports 2. Keys are now produced as buffers. If you pass one in as a string it will be converted. 3. Topic objects have been removed. You should use topic name strings to create topics. Re 1) Probably not applicable here. Re 2) Not applicable since it for producers only AFAIU. Re 3) We already use strings for topics in our Consumer. As a plus some deprecation warnings got removed when running npm install. [1] https://github.com/Blizzard/node-rdkafka/releases Bug: T179786 Change-Id: Icd5d6183c0e7358287e4fc20da6210281f9692d9 --- M package.json 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits refs/changes/46/390546/1 diff --git a/package.json b/package.json index 40b3d40..c49303e 100644 --- a/package.json +++ b/package.json @@ -33,7 +33,7 @@ "preq": "^0.4.10", "service-runner": "^2.2.5", "swagger-router": "^0.4.6", - "node-rdkafka": "^1.0.6", + "node-rdkafka": "^2.2.0", "wikipedia-edits-scorer": "^1.5.7" }, "devDependencies": { -- To view, visit https://gerrit.wikimedia.org/r/390546 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd5d6183c0e7358287e4fc20da6210281f9692d9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/trending-edits Gerrit-Branch: master Gerrit-Owner: BearND <bsitzm...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
