Filippo Giunchedi has uploaded a new change for review. https://gerrit.wikimedia.org/r/222205
Change subject: monitoring: validate service description for illegal characters ...................................................................... monitoring: validate service description for illegal characters Bug: T101799 Change-Id: Ifd2ae22206b759380579b2abac55aae67b490022 --- M modules/monitoring/manifests/service.pp 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/05/222205/1 diff --git a/modules/monitoring/manifests/service.pp b/modules/monitoring/manifests/service.pp index a56e733..437a6d7 100644 --- a/modules/monitoring/manifests/service.pp +++ b/modules/monitoring/manifests/service.pp @@ -14,6 +14,9 @@ $config_dir = '/etc/nagios', ) { + # default value for illegal_object_name_chars nagios/icinga option + validate_re($description, '^[^`~!$%^&*"|\'<>?,()=]+$') + if ! $host { fail("Parameter ${host} not defined!") } -- To view, visit https://gerrit.wikimedia.org/r/222205 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd2ae22206b759380579b2abac55aae67b490022 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits