[MediaWiki-commits] [Gerrit] oojs/ui[master]: Corrent some code comments in PHP mixins

[Code Review]

Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/302059

Change subject: Corrent some code comments in PHP mixins
......................................................................

Corrent some code comments in PHP mixins

Change-Id: I58d8847d68a8eb24af2fd263f4976f7243a4b6c1
---
M php/mixins/AccessKeyedElement.php
M php/mixins/ButtonElement.php
M php/mixins/LabelElement.php
M php/mixins/TitledElement.php
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/59/302059/1

diff --git a/php/mixins/AccessKeyedElement.php 
b/php/mixins/AccessKeyedElement.php
index 2e03a17..7ed6964 100644
--- a/php/mixins/AccessKeyedElement.php
+++ b/php/mixins/AccessKeyedElement.php
@@ -30,7 +30,7 @@
         * @param string $config['accessKey'] AccessKey. If not provided, no 
accesskey will be added
         */
        public function initializeAccessKeyedElement( array $config = [] ) {
-               // Parent constructor
+               // Properties
                $this->accessKeyed = isset( $config['accessKeyed'] ) ? 
$config['accessKeyed'] : $element;
 
                // Initialization
diff --git a/php/mixins/ButtonElement.php b/php/mixins/ButtonElement.php
index 671ebb5..1a667b9 100644
--- a/php/mixins/ButtonElement.php
+++ b/php/mixins/ButtonElement.php
@@ -29,7 +29,7 @@
         * @param boolean $config['framed'] Render button with a frame 
(default: true)
         */
        public function initializeButtonElement( array $config = [] ) {
-               // Parent constructor
+               // Properties
                if ( ! $this instanceof Element ) {
                        throw new Exception( "ButtonElement trait can only be 
used on Element instances" );
                }
diff --git a/php/mixins/LabelElement.php b/php/mixins/LabelElement.php
index 43f04f8..21fe246 100644
--- a/php/mixins/LabelElement.php
+++ b/php/mixins/LabelElement.php
@@ -25,7 +25,7 @@
         * @param string|HtmlSnippet $config['label'] Label text
         */
        public function initializeLabelElement( array $config = [] ) {
-               // Parent constructor
+               // Properties
                // FIXME 'labelElement' is a very stupid way to call '$label'
                $this->label = isset( $config['labelElement'] ) ? 
$config['labelElement'] : new Tag( 'span' );
 
diff --git a/php/mixins/TitledElement.php b/php/mixins/TitledElement.php
index f4b46b4..ed2735f 100644
--- a/php/mixins/TitledElement.php
+++ b/php/mixins/TitledElement.php
@@ -28,7 +28,7 @@
         * @param string $config['title'] Title. If not provided, the static 
property 'title' is used.
         */
        public function initializeTitledElement( array $config = [] ) {
-               // Parent constructor
+               // Properties
                $this->titled = isset( $config['titled'] ) ? $config['titled'] 
: $this;
 
                // Initialization

-- 
To view, visit https://gerrit.wikimedia.org/r/302059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58d8847d68a8eb24af2fd263f4976f7243a4b6c1
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits