VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/324014
Change subject: MediaWiki theme: Bring ButtonElement icon state change closer
to color
......................................................................
MediaWiki theme: Bring ButtonElement icon state change closer to color
Making flagged ButtonElement's icon change on `:hover` more similar to
change of color.
Change-Id: I5b8c2d8db8246e231e67a7ece1cbba8ced6ead4c
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/14/324014/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index ec7d6a7..7a9881a 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -112,6 +112,8 @@
@opacity-icon-default: 0.87; // equals `#222` on background-color `#fff`
@opacity-icon-default-hover: 0.73; // equals `#454545` on background-color
`#fff`, closest to `#444`
@opacity-icon-default-selected: 1;
+@opacity-icon-flagged: 1;
+@opacity-icon-flagged-hover: 0.8; // not exactly 20% brightness like color –
due to `opacity` limitations
// Transition variables
// Some of these values are duplicated in OO.ui.MediaWikiTheme
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 1db47ab..10b29a1 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -130,14 +130,14 @@
> .oo-ui-buttonElement-button {
> .oo-ui-iconElement-icon,
> .oo-ui-indicatorElement-indicator {
- opacity:
@opacity-icon-default-selected;
+ opacity: @opacity-icon-flagged;
}
}
> .oo-ui-buttonElement-button:hover {
> .oo-ui-iconElement-icon,
> .oo-ui-indicatorElement-indicator {
- opacity:
@opacity-icon-default-hover;
+ opacity:
@opacity-icon-flagged-hover;
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/324014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b8c2d8db8246e231e67a7ece1cbba8ced6ead4c
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
