Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352735 )

Change subject: OptionWidget: Use parent selector for icon/indicator/label 
styles
......................................................................

OptionWidget: Use parent selector for icon/indicator/label styles

This was using a descendant selector, which affected icons, indicators
and labels inside of other widgets that were put inside OptionWidgets.

Bug: T164550
Change-Id: Ib52025c4ad4c3f3a10064d7ecef571d9087e33aa
---
M src/styles/widgets/DecoratedOptionWidget.less
M src/styles/widgets/OptionWidget.less
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/35/352735/1

diff --git a/src/styles/widgets/DecoratedOptionWidget.less 
b/src/styles/widgets/DecoratedOptionWidget.less
index 744e730..2a230d4 100644
--- a/src/styles/widgets/DecoratedOptionWidget.less
+++ b/src/styles/widgets/DecoratedOptionWidget.less
@@ -1,8 +1,8 @@
 @import '../common';
 
 .oo-ui-decoratedOptionWidget {
-       .oo-ui-iconElement-icon,
-       .oo-ui-indicatorElement-indicator {
+       > .oo-ui-iconElement-icon,
+       > .oo-ui-indicatorElement-indicator {
                position: absolute;
        }
 
diff --git a/src/styles/widgets/OptionWidget.less 
b/src/styles/widgets/OptionWidget.less
index 837532b..cfdf71b 100644
--- a/src/styles/widgets/OptionWidget.less
+++ b/src/styles/widgets/OptionWidget.less
@@ -11,7 +11,7 @@
                cursor: default;
        }
 
-       &.oo-ui-labelElement .oo-ui-labelElement-label {
+       &.oo-ui-labelElement > .oo-ui-labelElement-label {
                display: block;
                white-space: nowrap;
                text-overflow: ellipsis;

-- 
To view, visit https://gerrit.wikimedia.org/r/352735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52025c4ad4c3f3a10064d7ecef571d9087e33aa
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to