jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/375865 )
Change subject: tests: Make MockWidget filename match class name
......................................................................
tests: Make MockWidget filename match class name
This fixes all of the issues from the
MediaWiki.Files.ClassMatchesFilename.NotMatch sniff.
Change-Id: I22a4833e704a3f148fb063ac1dd19557e4d27c8a
---
M composer.json
M phpcs.xml
R tests/phpunit/MockWidget.php
3 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/composer.json b/composer.json
index 129bcff..8a4b9f9 100644
--- a/composer.json
+++ b/composer.json
@@ -62,7 +62,7 @@
"autoload-dev": {
"classmap": [
"tests/phpunit/TestCase.php",
- "tests/phpunit/DummyWidget.php"
+ "tests/phpunit/MockWidget.php"
]
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 2bf38c1..742566f 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -8,7 +8,6 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<!-- Together with the above, false positives in
WikimediaUITheme.php and others -->
<exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
- <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<!-- False positive for variadic arguments syntax in Tag.php -->
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
diff --git a/tests/phpunit/DummyWidget.php b/tests/phpunit/MockWidget.php
similarity index 100%
rename from tests/phpunit/DummyWidget.php
rename to tests/phpunit/MockWidget.php
--
To view, visit https://gerrit.wikimedia.org/r/375865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22a4833e704a3f148fb063ac1dd19557e4d27c8a
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
