Nemo bis has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/354608 )
Change subject: Restore default $wgFlaggedRevsStatsAge (2 hours)
......................................................................
Restore default $wgFlaggedRevsStatsAge (2 hours)
Not clear what this setting is trying to achieve.
The update_flaggedrev_stats cronjob in operations/puppet
(modules/mediawiki/manifests/maintenance/update_flaggedrev_stats.pp)
is run every 2 hours.
FlaggedRevsStats::updateCache() is trying to set an object cache key
with expiry time of "false", which at least in SqlBagOStuff::setMulti()
gets cast to 0 and replaced by the maximum time value allowed by the
database. This doesn't seem very meaningful.
Bug: T163107
Change-Id: Iac5d38c053d6d5c5fd7f0ceb497d6c8a796895b8
---
M wmf-config/flaggedrevs.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/08/354608/1
diff --git a/wmf-config/flaggedrevs.php b/wmf-config/flaggedrevs.php
index 9982e90..e5623d9 100644
--- a/wmf-config/flaggedrevs.php
+++ b/wmf-config/flaggedrevs.php
@@ -780,5 +780,3 @@
$wgRemoveGroups['bureaucrat'][] = 'reviewer'; // demote from
full reviewers
}
}
-
-$wgFlaggedRevsStatsAge = false;
--
To view, visit https://gerrit.wikimedia.org/r/354608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac5d38c053d6d5c5fd7f0ceb497d6c8a796895b8
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Nemo bis <federicol...@tiscali.it>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
