Rush has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367710 )
Change subject: diamond: set diskusage filesystems explicitly ...................................................................... diamond: set diskusage filesystems explicitly Newer versions of diamond seem to include nfsv4 instead of just nfs and that means picking up the NFS shares for any server that mounts them which is useless for us. I noticed we are also currently not tracking some non-default filesystems I believe we want such as fuse.fuse_dfs (hdfs) on stat1003: Ignoring /mnt/hdfs since it is of type \ fuse.fuse_dfs which is not in the list of filesystems Bug: T171583 Change-Id: I633ccd19b26f7cd40ec8a2db371fb639a7ce142a --- M modules/diamond/manifests/init.pp 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/10/367710/1 diff --git a/modules/diamond/manifests/init.pp b/modules/diamond/manifests/init.pp index 61deb44..ecce144 100644 --- a/modules/diamond/manifests/init.pp +++ b/modules/diamond/manifests/init.pp @@ -117,7 +117,16 @@ } diamond::collector { 'Network': } - diamond::collector { 'DiskSpace': } + diamond::collector { 'DiskSpace': + settings => { + # lint:ignore:quoted_booleans + # As per comments above, these must be quoted for the config + # file. + filesystems => 'ext2, ext3, ext4, xfs, fuse.fuse_dfs, hfs, fat32, fat16, btrfs', + normalize => 'true', + # lint:endignore + }, + diamond::collector { 'LoadAverage': } diamond::collector { 'Memory': } diamond::collector { 'VMStat': } -- To view, visit https://gerrit.wikimedia.org/r/367710 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I633ccd19b26f7cd40ec8a2db371fb639a7ce142a Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Rush <r...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits