Aaron Schulz has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377451 )
Change subject: [WIP] Avoid warnings for invalid lines in reverse-stack mode ...................................................................... [WIP] Avoid warnings for invalid lines in reverse-stack mode Bug: T169249 Change-Id: I43e21d83d8fc8757d418e2f4baec0181cc752062 --- M modules/xenon/files/flamegraph.pl 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/51/377451/1 diff --git a/modules/xenon/files/flamegraph.pl b/modules/xenon/files/flamegraph.pl index bf00a04..4a94fe5 100755 --- a/modules/xenon/files/flamegraph.pl +++ b/modules/xenon/files/flamegraph.pl @@ -495,6 +495,11 @@ # there may be an extra samples column for differentials # XXX todo: redo these REs as one. It's repeated below. my ($stack, $samples) = (/^(.*)\s+?(\d+(?:\.\d*)?)$/); + unless (defined $samples and defined $stack) { + # Invalid line will be ignored later on + unshift @Data, $line; + next; + } my $samples2 = undef; if ($stack =~ /^(.*)\s+?(\d+(?:\.\d*)?)$/) { $samples2 = $samples; -- To view, visit https://gerrit.wikimedia.org/r/377451 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43e21d83d8fc8757d418e2f4baec0181cc752062 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits