Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/379830 )

Change subject: [WIP] webperf: Add navtiming tests to puppet.git:/tox.ini
......................................................................

[WIP] webperf: Add navtiming tests to puppet.git:/tox.ini

Change-Id: I2fdb8e0b978b2406ebc386c716c6c4321aeff0d8
---
M modules/webperf/files/navtiming.py
M tox.ini
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/30/379830/1

diff --git a/modules/webperf/files/navtiming.py 
b/modules/webperf/files/navtiming.py
index d288852..b000395 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -13,8 +13,6 @@
 import unittest
 import yaml
 
-from kafka import KafkaConsumer
-
 handlers = {}
 
 # Mapping of continent names to ISO 3166 country codes.
@@ -402,6 +400,8 @@
 
 
 if __name__ == '__main__':
+    from kafka import KafkaConsumer
+
     ap = argparse.ArgumentParser(description='NavigationTiming subscriber')
     ap.add_argument('--brokers', required=True,
                     help='Comma-separated list of kafka brokers')
diff --git a/tox.ini b/tox.ini
index b32a194..8f4eb50 100644
--- a/tox.ini
+++ b/tox.ini
@@ -31,6 +31,9 @@
     -rmodules/admin/data/requirements.txt
 commands = nosetests modules/admin/data 
modules/mediawiki/files/apache/sites/redirects
 
+[testenv:webperf]
+commands = nosetests modules/webperf/files
+
 [testenv:commit-message]
 deps = commit-message-validator
 commands = commit-message-validator

-- 
To view, visit https://gerrit.wikimedia.org/r/379830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fdb8e0b978b2406ebc386c716c6c4321aeff0d8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to