Herron has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376048 )

Change subject: WIP: Change check_ipmi_temp to check_ipmi_sensor and monitor 
PSUs
......................................................................

WIP: Change check_ipmi_temp to check_ipmi_sensor and monitor PSUs

Repurpose existing ipmi temp check as generic ipmi sensor check.  Rename
check_ipmi_temperature to check_ipmi_sensor.  Monitor Power_Supply sensor.

Bug: T109903
Change-Id: Ic4a764fb92f9f4f75d2afc59b520a1f8faf2b07c
---
M modules/ipmi/manifests/monitor.pp
1 file changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/48/376048/1

diff --git a/modules/ipmi/manifests/monitor.pp 
b/modules/ipmi/manifests/monitor.pp
index 964f69f..2690a63 100644
--- a/modules/ipmi/manifests/monitor.pp
+++ b/modules/ipmi/manifests/monitor.pp
@@ -14,14 +14,20 @@
         ensure => present,
     }
 
+    # rename nagios_ipmi_temp to nagios_ipmi_sensor
+    # this ensure absent can be removed after propagation
     ::sudo::user { 'nagios_ipmi_temp':
+        ensure     => absent,
+    }
+
+    ::sudo::user { 'nagios_ipmi_sensor':
         user       => 'nagios',
         privileges => ['ALL = NOPASSWD: /usr/sbin/ipmi-sel, 
/usr/sbin/ipmi-sensors'],
     }
 
-    nrpe::monitor_service { 'check_ipmi_temp':
-        description    => 'IPMI Temperature',
-        nrpe_command   => '/usr/local/lib/nagios/plugins/check_ipmi_sensor 
--noentityabsent -T Temperature -ST Temperature --nosel',
+    nrpe::monitor_service { 'check_ipmi_sensor':
+        description    => 'IPMI Sensor Status',
+        nrpe_command   => '/usr/local/lib/nagios/plugins/check_ipmi_sensor 
--noentityabsent -T Temperature -T Power_Supply --nosel',
         check_interval => 30,
         retry_interval => 10,
         timeout        => 60,

-- 
To view, visit https://gerrit.wikimedia.org/r/376048
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4a764fb92f9f4f75d2afc59b520a1f8faf2b07c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Herron <kher...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to