Stan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176254
Change subject: remove non applicable private (per rubocop)
......................................................................
remove non applicable private (per rubocop)
Bug: T75898
Change-Id: I2ac4926bfd4e9bd99cb4c7394709847a46c0460d
---
M .rubocop_todo.yml
M lib/mediawiki_selenium/warnings_formatter.rb
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/54/176254/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 05e78fc..ee3ef98 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -5,10 +5,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 1
-Lint/UselessAccessModifier:
- Enabled: false
-
# Offense count: 2
Metrics/CyclomaticComplexity:
Max: 16
diff --git a/lib/mediawiki_selenium/warnings_formatter.rb
b/lib/mediawiki_selenium/warnings_formatter.rb
index 53b730e..ab51b0f 100644
--- a/lib/mediawiki_selenium/warnings_formatter.rb
+++ b/lib/mediawiki_selenium/warnings_formatter.rb
@@ -34,8 +34,6 @@
feature.extend(FeatureWarnings)
end
- private
-
module FeatureWarnings
def mw_warn(message, type = :default)
mw_warnings[type] ||= []
--
To view, visit https://gerrit.wikimedia.org/r/176254
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ac4926bfd4e9bd99cb4c7394709847a46c0460d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Stan <tris...@saticed.me.uk>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
