Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/81844
Change subject: sigh, quote 'true' because webserver.pp does treat them as
strings
......................................................................
sigh, quote 'true' because webserver.pp does treat them as strings
..maybe this should be fixed in webserver.pp:
if $ssl in ["true", "only", "redirected"] {
because if you don't (like you should) you get:
'true' from left operand of 'in' expression is not a string
at /etc/puppet/manifests/webserver.pp:296
Change-Id: Id4977d0bee57dd3a57dcbfb4edd87af0049e25b1
---
M manifests/misc/statistics.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/44/81844/1
diff --git a/manifests/misc/statistics.pp b/manifests/misc/statistics.pp
index 403cf34..c86053b 100644
--- a/manifests/misc/statistics.pp
+++ b/manifests/misc/statistics.pp
@@ -263,7 +263,7 @@
webserver::apache::site { $site_name:
require => [Class["webserver::apache"],
Webserver::Apache::Module["rewrite"], File["/etc/apache2/htpasswd.stats"]],
docroot => $docroot,
- ssl => true,
+ ssl => 'true',
certfile => '/etc/ssl/certs/stats.wikimedia.org.chained.pem',
certkey => '/etc/ssl/private/stats.wikimedia.org.key',
aliases => ["stats.wikipedia.org"],
--
To view, visit https://gerrit.wikimedia.org/r/81844
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4977d0bee57dd3a57dcbfb4edd87af0049e25b1
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
