Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/204727
Change subject: statsite: allow instance settings to be fetched from hiera
......................................................................
statsite: allow instance settings to be fetched from hiera
port has been left out because it is expected to be instantiated per-instance
explicitly in manifests, hostname would yield surprises because AFAIK hiera
wouldn't expand variables e.g. ${::hostname} if specified
Change-Id: I1dd21ce3e9432751d50a8c6ca2fdcb1434f696bd
---
M modules/statsite/manifests/instance.pp
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/27/204727/1
diff --git a/modules/statsite/manifests/instance.pp
b/modules/statsite/manifests/instance.pp
index 2b4c5f0..f8dc4e4 100644
--- a/modules/statsite/manifests/instance.pp
+++ b/modules/statsite/manifests/instance.pp
@@ -22,9 +22,9 @@
define statsite::instance(
$port = 8125,
$graphite_host =
hiera('statsite::instance::graphite_host','graphite-in.eqiad.wmnet'),
- $graphite_port = 2003,
+ $graphite_port = hiera('statsite::instance::graphite_port', 2003),
$input_counter = "statsd.${::hostname}.received",
- $extended_counters = 0,
+ $extended_counters = hiera('statsite::instance::extended_counters', 0),
) {
$stream_cmd = "python /usr/lib/statsite/sinks/graphite.py $graphite_host
$graphite_port \"\""
--
To view, visit https://gerrit.wikimedia.org/r/204727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dd21ce3e9432751d50a8c6ca2fdcb1434f696bd
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
