Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/88758


Change subject: tranclusion elements to new 3rd iframe
......................................................................

tranclusion elements to new 3rd iframe

Change-Id: Ia1a02ece54c44d3bfb0dd985fec97e9c8d5b9d59
---
M 
modules/ve-mw/test/browser/features/step_definitions/visual_editor_transclusion_steps.rb
M modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
2 files changed, 13 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/58/88758/1

diff --git 
a/modules/ve-mw/test/browser/features/step_definitions/visual_editor_transclusion_steps.rb
 
b/modules/ve-mw/test/browser/features/step_definitions/visual_editor_transclusion_steps.rb
index a66c09c..bf2c7f0 100644
--- 
a/modules/ve-mw/test/browser/features/step_definitions/visual_editor_transclusion_steps.rb
+++ 
b/modules/ve-mw/test/browser/features/step_definitions/visual_editor_transclusion_steps.rb
@@ -1,5 +1,10 @@
 Given(/^I can see the Transclusion User Interface$/) do
-  on(VisualEditorPage).title.should match 'Transclusion'
+  on(VisualEditorPage) do |page|
+    page.wait_until(10) do
+      page.title.include? 'Transclusion'
+    end
+    page.title.should match 'Transclusion'
+  end
 end
 
 When(/^I add the parameter$/) do
diff --git 
a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb 
b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
index d3fb270..238e789 100644
--- a/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/test/browser/features/support/pages/visual_editor_page.rb
@@ -61,19 +61,21 @@
     span(:subheading4, text: 'Sub-heading 4')
     list_item(:template_list_item, text: 'S', frame: frame)
     div(:ve_link_ui, class: 've-ui-window-head', frame: frame)
-    div(:title, class: 've-ui-window-title', frame: frame)
     div(:uparrow, class:'ve-init-mw-viewPageTarget-saveDialog-closeButton')
     span(:ve_heading_ui, text: 'Paragraph')
   end
 
   in_frame(:index => 1) do |frame|
     a(:beta_warning, title: 'Close', frame: frame)
-    span(:apply_changes, text: 'Apply changes', frame: frame)
-    span(:add_parameter, class: 've-ui-mwParameterResultWidget-name', frame: 
frame)
-    span(:add_template, text: 'Add template', frame: frame)
     div(:ref_body, class:'ve-ui-window-head', frame: frame)
     div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame: 
frame)
     div(:insert_reference, text: 'Insert reference', frame: frame)
+  end
+
+  in_frame(:index => 2) do |frame|
+    span(:add_parameter, class: 've-ui-mwParameterResultWidget-name', frame: 
frame)
+    span(:add_template, text: 'Add template', frame: frame)
+    span(:apply_changes, text: 'Apply changes', frame: frame)
     text_field(:parameter_box, index: 0, frame: frame)
     span(:remove_parameter, text: 'Remove parameter', frame: frame)
     span(:remove_template, text: 'Remove template', frame: frame)
@@ -82,4 +84,5 @@
     text_field(:transclusion_textfield, index: 0, frame: frame)
     unordered_list(:suggestion_list, class: 've-ui-widget ve-ui-selectWidget 
ve-ui-clippableElement-clippable ve-ui-menuWidget ve-ui-textInputMenuWidget 
ve-ui-lookupWidget-menu ve-ui-mwTitleInputWidget-menu', frame: frame)
   end
+
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/88758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1a02ece54c44d3bfb0dd985fec97e9c8d5b9d59
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to