[MediaWiki-commits] [Gerrit] Adjust description of ApiWikiLoveImageLog - change (mediawiki...WikiLove)

2014-03-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/117914 Change subject: Adjust description of ApiWikiLoveImageLog .. Adjust description of ApiWikiLoveImageLog "This API" is not a good start f

[MediaWiki-commits] [Gerrit] Add final period to API module descriptions - change (mediawiki...CodeReview)

2014-03-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/117925 Change subject: Add final period to API module descriptions .. Add final period to API module descriptions Change-Id: Ibcd1004173775001

[MediaWiki-commits] [Gerrit] Adjust magic bolding in api help to only match lines inside * - change (mediawiki/core)

2014-03-11 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118130 Change subject: Adjust magic bolding in api help to only match lines inside * .. Adjust magic bolding in api help to only match lines in

[MediaWiki-commits] [Gerrit] Pass $user to LocalFileDeleteBatch - change (mediawiki/core)

2014-05-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/131761 Change subject: Pass $user to LocalFileDeleteBatch .. Pass $user to LocalFileDeleteBatch This avoids the use of $wgUser Change-Id: I60

[MediaWiki-commits] [Gerrit] Adjust declaration of ForeignDBFile::delete() - change (mediawiki/core)

2014-05-07 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132002 Change subject: Adjust declaration of ForeignDBFile::delete() .. Adjust declaration of ForeignDBFile::delete() Strict Standards: Declar

[MediaWiki-commits] [Gerrit] jquery.accessKeyLabel: Replace hardcoded brackets and space - change (mediawiki/core)

2014-05-07 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132009 Change subject: jquery.accessKeyLabel: Replace hardcoded brackets and space .. jquery.accessKeyLabel: Replace hardcoded brackets and spa

[MediaWiki-commits] [Gerrit] wikibits deprecations: Do not offer another deprecated function - change (mediawiki/core)

2014-05-07 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132014 Change subject: wikibits deprecations: Do not offer another deprecated function .. wikibits deprecations: Do not offer another deprecate

[MediaWiki-commits] [Gerrit] Avoid mw.config and mw.messages in qunit setup - change (mediawiki/core)

2014-05-07 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132016 Change subject: Avoid mw.config and mw.messages in qunit setup .. Avoid mw.config and mw.messages in qunit setup It is possible to give

[MediaWiki-commits] [Gerrit] Add comment about desc message to $wgTrackingCategories - change (mediawiki/core)

2014-05-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132462 Change subject: Add comment about desc message to $wgTrackingCategories .. Add comment about desc message to $wgTrackingCategories Chan

[MediaWiki-commits] [Gerrit] Fix title handling in User::getCanonicalName - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132610 Change subject: Fix title handling in User::getCanonicalName .. Fix title handling in User::getCanonicalName With r41328 the title vali

[MediaWiki-commits] [Gerrit] Add space between two feed links - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132621 Change subject: Add space between two feed links .. Add space between two feed links When more than one feed link was given, the links

[MediaWiki-commits] [Gerrit] Fix HISTORY hint in RELEASE-NOTES-1.24 - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132682 Change subject: Fix HISTORY hint in RELEASE-NOTES-1.24 .. Fix HISTORY hint in RELEASE-NOTES-1.24 Was missed for RELEASE-NOTES-1.23 and

[MediaWiki-commits] [Gerrit] Fix HISTORY hint in RELEASE-NOTES-1.23 - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132681 Change subject: Fix HISTORY hint in RELEASE-NOTES-1.23 .. Fix HISTORY hint in RELEASE-NOTES-1.23 Was not updated the last time when REL

[MediaWiki-commits] [Gerrit] Fix HISTORY hint in RELEASE-NOTES-1.23 - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132686 Change subject: Fix HISTORY hint in RELEASE-NOTES-1.23 .. Fix HISTORY hint in RELEASE-NOTES-1.23 Was not updated the last time when REL

[MediaWiki-commits] [Gerrit] Remove B/C classes WatchlistEditor and IPBlockForm - change (mediawiki/core)

2014-05-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132704 Change subject: Remove B/C classes WatchlistEditor and IPBlockForm .. Remove B/C classes WatchlistEditor and IPBlockForm There was a re

[MediaWiki-commits] [Gerrit] Adjust message 'visualeditor-dialog-beta-welcome-content' - change (mediawiki...VisualEditor)

2014-05-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/132962 Change subject: Adjust message 'visualeditor-dialog-beta-welcome-content' .. Adjust message 'visualeditor-dialog-beta-welcome-content'

[MediaWiki-commits] [Gerrit] Expand doc of ApiBase::require*Parameter functions - change (mediawiki/core)

2014-05-13 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/133102 Change subject: Expand doc of ApiBase::require*Parameter functions .. Expand doc of ApiBase::require*Parameter functions Add a hint to

[MediaWiki-commits] [Gerrit] Add @since to Skin::getAllowedSkins - change (mediawiki/core)

2014-04-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126037 Change subject: Add @since to Skin::getAllowedSkins .. Add @since to Skin::getAllowedSkins Follow-Up: I0b0fdfb5615c22aa876882c3ca344ebb

[MediaWiki-commits] [Gerrit] Avoid implict User::__toString - change (mediawiki/core)

2014-04-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126041 Change subject: Avoid implict User::__toString .. Avoid implict User::__toString Follow-Up: Ie07001e75a9732f727930f8f367bba8feb395b3e C

[MediaWiki-commits] [Gerrit] Remove redirectToFragment() from wikibits.js - change (mediawiki/core)

2014-04-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126060 Change subject: Remove redirectToFragment() from wikibits.js .. Remove redirectToFragment() from wikibits.js Replaced by module mediawi

[MediaWiki-commits] [Gerrit] Allow LogEntry::setRelations to work with array(tag => value) - change (mediawiki/core)

2014-04-16 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126724 Change subject: Allow LogEntry::setRelations to work with array(tag => value) .. Allow LogEntry::setRelations to work with array(tag =>

[MediaWiki-commits] [Gerrit] Fixes to Special:TrackingCategories - change (mediawiki/core)

2014-04-17 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126950 Change subject: Fixes to Special:TrackingCategories .. Fixes to Special:TrackingCategories - Message::isDisabled is using the unparsed

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (skins) - change (mediawiki/core)

2014-04-17 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/126967 Change subject: Fixed some @params documentation (skins) .. Fixed some @params documentation (skins) Swapped some "$var type" to "type

[MediaWiki-commits] [Gerrit] Remove superfluous # at end of line from languages.inc - change (mediawiki/core)

2014-04-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/127274 Change subject: Remove superfluous # at end of line from languages.inc .. Remove superfluous # at end of line from languages.inc Change

[MediaWiki-commits] [Gerrit] Remove # from dataProvider - change (mediawiki/core)

2014-04-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/127276 Change subject: Remove # from dataProvider .. Remove # from dataProvider Change-Id: Ie5414173b95e846d735827bffa34c73698e48c17 --- M tes

[MediaWiki-commits] [Gerrit] docs: closure -> Closure; callback -> callable - change (mediawiki/core)

2014-04-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/127422 Change subject: docs: closure -> Closure; callback -> callable .. docs: closure -> Closure; callback -> callable Changed closure to cap

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/*) - change (mediawiki/core)

2014-04-19 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/127449 Change subject: Fixed some @params documentation (includes/*) .. Fixed some @params documentation (includes/*) Swapped some "$var type"

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/*) - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129117 Change subject: Fixed some @params documentation (includes/*) .. Fixed some @params documentation (includes/*) Swapped some "$var type"

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/WikiPage.php) - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129121 Change subject: Fixed some @params documentation (includes/WikiPage.php) .. Fixed some @params documentation (includes/WikiPage.php) Sw

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/[Block.php|Revisi... - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129124 Change subject: Fixed some @params documentation (includes/[Block.php|Revision.php]) .. Fixed some @params documentation (includes/[Blo

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/[Export.php|Impor... - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129125 Change subject: Fixed some @params documentation (includes/[Export.php|Import.php]) .. Fixed some @params documentation (includes/[Expo

[MediaWiki-commits] [Gerrit] Fixed some @params documentation (includes/[WebRequest.php|X... - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129126 Change subject: Fixed some @params documentation (includes/[WebRequest.php|Xml.php]) .. Fixed some @params documentation (includes/[Web

[MediaWiki-commits] [Gerrit] Follow-Ups to "Fixed some @params documentation" - change (mediawiki/core)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129148 Change subject: Follow-Ups to "Fixed some @params documentation" .. Follow-Ups to "Fixed some @params documentation" Fix of inline comm

[MediaWiki-commits] [Gerrit] window.localStorage can be null in IE11 - change (mediawiki...CentralAuth)

2014-04-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129245 Change subject: window.localStorage can be null in IE11 .. window.localStorage can be null in IE11 That gives a error, when the 'getIte

[MediaWiki-commits] [Gerrit] RevisionDelete: Avoid SELECT * - change (mediawiki/core)

2014-04-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129382 Change subject: RevisionDelete: Avoid SELECT * .. RevisionDelete: Avoid SELECT * Use selectFields functions and a manually list of colu

[MediaWiki-commits] [Gerrit] [Regression] Delete autoblocks when removing autoblock flag - change (mediawiki/core)

2014-03-23 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/120386 Change subject: [Regression] Delete autoblocks when removing autoblock flag .. [Regression] Delete autoblocks when removing autoblock fl

[MediaWiki-commits] [Gerrit] Allow access to revision deleted wikitext on action=edit - change (mediawiki/core)

2014-03-25 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/120858 Change subject: Allow access to revision deleted wikitext on action=edit .. Allow access to revision deleted wikitext on action=edit Ed

[MediaWiki-commits] [Gerrit] Remove unneeded $classes from SpecialTrackingCategories.php - change (mediawiki/core)

2014-05-16 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/133723 Change subject: Remove unneeded $classes from SpecialTrackingCategories.php .. Remove unneeded $classes from SpecialTrackingCategories.p

[MediaWiki-commits] [Gerrit] Fix @since of Parser::stripOuterParagraph - change (mediawiki/core)

2014-05-16 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/133752 Change subject: Fix @since of Parser::stripOuterParagraph .. Fix @since of Parser::stripOuterParagraph Was merged after release branch.

[MediaWiki-commits] [Gerrit] Use anonym function in Linker::formatAutocomments/formatLink... - change (mediawiki/core)

2014-05-16 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/133773 Change subject: Use anonym function in Linker::formatAutocomments/formatLinksInComment .. Use anonym function in Linker::formatAutocomm

[MediaWiki-commits] [Gerrit] Adjust check of MysqlUpdater::doUpdateMimeMinorField - change (mediawiki/core)

2014-05-18 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/133984 Change subject: Adjust check of MysqlUpdater::doUpdateMimeMinorField .. Adjust check of MysqlUpdater::doUpdateMimeMinorField The patch

[MediaWiki-commits] [Gerrit] Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErro... - change (mediawiki/core)

2014-05-20 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/134469 Change subject: Add error 'pagecannotexist' to ApiBase::getTitleOrPageIdErrorMessage .. Add error 'pagecannotexist' to ApiBase::getTitl

[MediaWiki-commits] [Gerrit] Add missing possible errors to ApiRollback.php - change (mediawiki/core)

2014-05-20 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/134470 Change subject: Add missing possible errors to ApiRollback.php .. Add missing possible errors to ApiRollback.php requireOnlyOneParamete

[MediaWiki-commits] [Gerrit] Add dynamic maxlength to Special:RevisionDelete - change (mediawiki/core)

2014-05-24 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135197 Change subject: Add dynamic maxlength to Special:RevisionDelete .. Add dynamic maxlength to Special:RevisionDelete A reason on Special:

[MediaWiki-commits] [Gerrit] Swap if/elseif in SpecialRevisiondelete.php - change (mediawiki/core)

2014-05-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135444 Change subject: Swap if/elseif in SpecialRevisiondelete.php .. Swap if/elseif in SpecialRevisiondelete.php This avoids checking $commen

[MediaWiki-commits] [Gerrit] Change one Linker::formatSize call to Message::sizeParams - change (mediawiki/core)

2014-05-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135448 Change subject: Change one Linker::formatSize call to Message::sizeParams .. Change one Linker::formatSize call to Message::sizeParams

[MediaWiki-commits] [Gerrit] Use language from context in Skin::subPageSubtitle - change (mediawiki/core)

2014-05-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/135449 Change subject: Use language from context in Skin::subPageSubtitle .. Use language from context in Skin::subPageSubtitle Change-Id: Ia6

[MediaWiki-commits] [Gerrit] Add version comments for 1.24 to all updaters - change (mediawiki/core)

2014-04-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129892 Change subject: Add version comments for 1.24 to all updaters .. Add version comments for 1.24 to all updaters pp_sortkey was added wit

[MediaWiki-commits] [Gerrit] http -> https rewrite: Only replace one http by https - change (mediawiki/core)

2014-04-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129925 Change subject: http -> https rewrite: Only replace one http by https .. http -> https rewrite: Only replace one http by https This avo

[MediaWiki-commits] [Gerrit] Use strict array_search in DatabasePostgres.php - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129936 Change subject: Use strict array_search in DatabasePostgres.php .. Use strict array_search in DatabasePostgres.php array_search( 'FOR U

[MediaWiki-commits] [Gerrit] $wgEnotifUseRealName: Check, if realname is non-empty - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129940 Change subject: $wgEnotifUseRealName: Check, if realname is non-empty .. $wgEnotifUseRealName: Check, if realname is non-empty When $wg

[MediaWiki-commits] [Gerrit] Set autofocus on Special:Unblock - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129944 Change subject: Set autofocus on Special:Unblock .. Set autofocus on Special:Unblock Replaced the tabindex=1 with autofocus to have the

[MediaWiki-commits] [Gerrit] Remove tabindex from Special:Block - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129946 Change subject: Remove tabindex from Special:Block .. Remove tabindex from Special:Block There is a autofocus on the Target field, whic

[MediaWiki-commits] [Gerrit] Use Database methods in RevisionDeleteUser::setUsernameBitfi... - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129954 Change subject: Use Database methods in RevisionDeleteUser::setUsernameBitfields .. Use Database methods in RevisionDeleteUser::setUsern

[MediaWiki-commits] [Gerrit] Set mobile target for jquery.accessKeyLabel - change (mediawiki/core)

2014-04-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/129977 Change subject: Set mobile target for jquery.accessKeyLabel .. Set mobile target for jquery.accessKeyLabel mediawiki.util has target mo

[MediaWiki-commits] [Gerrit] Add $user param to Revision::newNullRevision - change (mediawiki/core)

2014-04-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/130096 Change subject: Add $user param to Revision::newNullRevision .. Add $user param to Revision::newNullRevision This avoids the use of $wg

[MediaWiki-commits] [Gerrit] Pass user and user_text to Revision constructor - change (mediawiki/core)

2014-04-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/130099 Change subject: Pass user and user_text to Revision constructor .. Pass user and user_text to Revision constructor This avoids the use

[MediaWiki-commits] [Gerrit] Remove linktrail equal to 'en' - change (mediawiki/core)

2014-04-30 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/130635 Change subject: Remove linktrail equal to 'en' .. Remove linktrail equal to 'en' The languages does not have a fallback language, which

[MediaWiki-commits] [Gerrit] Add missing @return in Language.php - change (mediawiki/core)

2014-04-30 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/130641 Change subject: Add missing @return in Language.php .. Add missing @return in Language.php Change-Id: I977bc5bf21235ce0f07cf0214597a37a

[MediaWiki-commits] [Gerrit] Adjust indent of some comment blocks - change (mediawiki/core)

2014-04-30 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/130655 Change subject: Adjust indent of some comment blocks .. Adjust indent of some comment blocks Change-Id: Ic25419490fa6a35c11ccc2b7810527

[MediaWiki-commits] [Gerrit] Add line number as id to diff block headers - change (mediawiki/core)

2014-05-02 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/131031 Change subject: Add line number as id to diff block headers .. Add line number as id to diff block headers Add line number from the lef

[MediaWiki-commits] [Gerrit] Add $user param to SpecialPageFactory::getRestrictedPages - change (mediawiki/core)

2014-05-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/131522 Change subject: Add $user param to SpecialPageFactory::getRestrictedPages .. Add $user param to SpecialPageFactory::getRestrictedPages

[MediaWiki-commits] [Gerrit] Avoid raw sql in LocalFileDeleteBatch::doDBInserts - change (mediawiki/core)

2014-05-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/131532 Change subject: Avoid raw sql in LocalFileDeleteBatch::doDBInserts .. Avoid raw sql in LocalFileDeleteBatch::doDBInserts Use Database::

[MediaWiki-commits] [Gerrit] fix typo in comment in Preferences.php - change (mediawiki/core)

2014-04-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124072 Change subject: fix typo in comment in Preferences.php .. fix typo in comment in Preferences.php The name of the preference was spelled

[MediaWiki-commits] [Gerrit] Fix spacing after @param and friends in comments - change (mediawiki/core)

2014-04-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124126 Change subject: Fix spacing after @param and friends in comments .. Fix spacing after @param and friends in comments Searched for: \@(p

[MediaWiki-commits] [Gerrit] Increase colspan for unattached rows on Special:CentralAuth - change (mediawiki...CentralAuth)

2014-04-05 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124127 Change subject: Increase colspan for unattached rows on Special:CentralAuth .. Increase colspan for unattached rows on Special:CentralAu

[MediaWiki-commits] [Gerrit] Changed some comments from /// to /** @var */ - change (mediawiki/core)

2014-04-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124167 Change subject: Changed some comments from /// to /** @var */ .. Changed some comments from /// to /** @var */ Change-Id: I55b30099e446

[MediaWiki-commits] [Gerrit] Fix [missing] variables in @param docs - change (mediawiki/core)

2014-04-06 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124168 Change subject: Fix [missing] variables in @param docs .. Fix [missing] variables in @param docs Two places found without variable, one

[MediaWiki-commits] [Gerrit] Avoid using raw sql in SpecialUndelete.php - change (mediawiki/core)

2014-04-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124659 Change subject: Avoid using raw sql in SpecialUndelete.php .. Avoid using raw sql in SpecialUndelete.php The where part for the ar_time

[MediaWiki-commits] [Gerrit] Avoid using raw sql in LinksUpdate.php - change (mediawiki/core)

2014-04-08 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124661 Change subject: Avoid using raw sql in LinksUpdate.php .. Avoid using raw sql in LinksUpdate.php Now the IN-List is created by the data

[MediaWiki-commits] [Gerrit] Avoid using raw sql in LocalFile.php - change (mediawiki/core)

2014-04-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124867 Change subject: Avoid using raw sql in LocalFile.php .. Avoid using raw sql in LocalFile.php Now the IN-List is created by the database

[MediaWiki-commits] [Gerrit] document.createElementNS is null or not an object in IE8 - change (mediawiki/core)

2014-04-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124905 Change subject: document.createElementNS is null or not an object in IE8 .. document.createElementNS is null or not an object in IE8 Ha

[MediaWiki-commits] [Gerrit] Restore text for "Other" reason on Special:Block reason list - change (mediawiki/core)

2014-04-09 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/124912 Change subject: Restore text for "Other" reason on Special:Block reason list .. Restore text for "Other" reason on Special:Block reason

[MediaWiki-commits] [Gerrit] HTMLSelectOtherFields: Have 'other' always as first element - change (mediawiki/core)

2014-04-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125209 Change subject: HTMLSelectOtherFields: Have 'other' always as first element .. HTMLSelectOtherFields: Have 'other' always as first eleme

[MediaWiki-commits] [Gerrit] Document new param of Title::countRevisionsBetween - change (mediawiki/core)

2014-04-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125239 Change subject: Document new param of Title::countRevisionsBetween .. Document new param of Title::countRevisionsBetween Follow-Up: Ie5

[MediaWiki-commits] [Gerrit] Remove trailing spaces from some language files - change (mediawiki/core)

2014-04-10 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125259 Change subject: Remove trailing spaces from some language files .. Remove trailing spaces from some language files Change-Id: I61d015a9

[MediaWiki-commits] [Gerrit] Add jquery.accessKeyLabel javascript module - change (mediawiki/core)

2014-04-11 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125426 Change subject: Add jquery.accessKeyLabel javascript module .. Add jquery.accessKeyLabel javascript module Extracted the accessKey logi

[MediaWiki-commits] [Gerrit] Add 'messages used' comment - change (mediawiki/core)

2014-04-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125567 Change subject: Add 'messages used' comment .. Add 'messages used' comment Change-Id: I69acea2a1f0a1ef6854d2ebddda446f86086633e --- M i

[MediaWiki-commits] [Gerrit] Fix RevDel_RevisionItem::getAuthorNameField to work for ips - change (mediawiki/core)

2014-04-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125568 Change subject: Fix RevDel_RevisionItem::getAuthorNameField to work for ips .. Fix RevDel_RevisionItem::getAuthorNameField to work for i

[MediaWiki-commits] [Gerrit] Format archive and filearchive revision delete log entries - change (mediawiki/core)

2014-04-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125572 Change subject: Format archive and filearchive revision delete log entries .. Format archive and filearchive revision delete log entries

[MediaWiki-commits] [Gerrit] Drop rc_cur_time from recentchanges - change (mediawiki/core)

2014-04-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125769 Change subject: Drop rc_cur_time from recentchanges .. Drop rc_cur_time from recentchanges Field was removed in 1.23 from sql statement

[MediaWiki-commits] [Gerrit] Remove unneeded rc_cur_time from RCCacheEntryFactoryTest - change (mediawiki/core)

2014-04-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125772 Change subject: Remove unneeded rc_cur_time from RCCacheEntryFactoryTest .. Remove unneeded rc_cur_time from RCCacheEntryFactoryTest Ch

[MediaWiki-commits] [Gerrit] Fixed @params documentation - change (mediawiki/core)

2014-04-14 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/125852 Change subject: Fixed @params documentation .. Fixed @params documentation Swapped some "$var type" to "type $var" or added missing typ

[MediaWiki-commits] [Gerrit] Fix spacing in SpecialRevisiondelete.php - change (mediawiki/core)

2014-03-12 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118325 Change subject: Fix spacing in SpecialRevisiondelete.php .. Fix spacing in SpecialRevisiondelete.php Change-Id: I5ae28e7e7b937ad4b60b91

[MediaWiki-commits] [Gerrit] Fix variable name of param doc in RCCacheEntryFactory - change (mediawiki/core)

2014-03-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118807 Change subject: Fix variable name of param doc in RCCacheEntryFactory .. Fix variable name of param doc in RCCacheEntryFactory Change-I

[MediaWiki-commits] [Gerrit] Rename some local vars to start with a lowercase letter - change (mediawiki/core)

2014-03-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118808 Change subject: Rename some local vars to start with a lowercase letter .. Rename some local vars to start with a lowercase letter Chan

[MediaWiki-commits] [Gerrit] Fix spacing between two functions - change (mediawiki/core)

2014-03-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118823 Change subject: Fix spacing between two functions .. Fix spacing between two functions Added and removed some new lines to have one new

[MediaWiki-commits] [Gerrit] Fix formatting of some php docs - change (mediawiki/core)

2014-03-15 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/118935 Change subject: Fix formatting of some php docs .. Fix formatting of some php docs php docs of functions should have newline in it and

[MediaWiki-commits] [Gerrit] Use square brackets instead of curly braces for char of a st... - change (mediawiki/core)

2014-03-19 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/119529 Change subject: Use square brackets instead of curly braces for char of a string .. Use square brackets instead of curly braces for char

[MediaWiki-commits] [Gerrit] Remove some unneeded local vars from EditPage.php - change (mediawiki/core)

2014-03-19 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/119536 Change subject: Remove some unneeded local vars from EditPage.php .. Remove some unneeded local vars from EditPage.php Looks like a lef

[MediaWiki-commits] [Gerrit] Fix possible error list of action=revisiondelete - change (mediawiki/core)

2014-03-20 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/119792 Change subject: Fix possible error list of action=revisiondelete .. Fix possible error list of action=revisiondelete Bug: 62853 Change-

[MediaWiki-commits] [Gerrit] Fixed spacing - change (mediawiki/core)

2014-03-20 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/119798 Change subject: Fixed spacing .. Fixed spacing - Added spaces after if/foreach/catch - Added new line before end of file - Added or rem

[MediaWiki-commits] [Gerrit] Accept null in HTMLRadioField::validate - change (mediawiki/core)

2014-03-22 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/120313 Change subject: Accept null in HTMLRadioField::validate .. Accept null in HTMLRadioField::validate Null will result in the default valu

[MediaWiki-commits] [Gerrit] Restore templatelinks count on info=action - change (mediawiki/core)

2014-01-26 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109506 Change subject: Restore templatelinks count on info=action .. Restore templatelinks count on info=action With I13b64db1 the list of th

[MediaWiki-commits] [Gerrit] Rollback: Make update of recentchanges table later - change (mediawiki/core)

2014-01-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109706 Change subject: Rollback: Make update of recentchanges table later .. Rollback: Make update of recentchanges table later Avoid update

[MediaWiki-commits] [Gerrit] Correct sequence name for fresh Postgres installation - change (mediawiki/core)

2014-01-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109713 Change subject: Correct sequence name for fresh Postgres installation .. Correct sequence name for fresh Postgres installation Spotted

[MediaWiki-commits] [Gerrit] Ignore 'unknown' in XFF - change (mediawiki/core)

2014-01-27 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109721 Change subject: Ignore 'unknown' in XFF .. Ignore 'unknown' in XFF Can come from Squid http://www.squid-cache.org/Doc/config/forwarded

[MediaWiki-commits] [Gerrit] Avoid variable naming conflicts in DatabasePostgres::selectS... - change (mediawiki/core)

2014-01-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109914 Change subject: Avoid variable naming conflicts in DatabasePostgres::selectSQLText .. Avoid variable naming conflicts in DatabasePostgr

[MediaWiki-commits] [Gerrit] Unroll array_map in ResourceLoaderFileModule::readStyleFiles - change (mediawiki/core)

2014-01-28 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/109956 Change subject: Unroll array_map in ResourceLoaderFileModule::readStyleFiles .. Unroll array_map in ResourceLoaderFileModule::readStyleF

[MediaWiki-commits] [Gerrit] mb_substr() expects parameter 2 to be long, string given - change (mediawiki...ParserFunctions)

2014-01-31 Thread Umherirrender (Code Review)
Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/110582 Change subject: mb_substr() expects parameter 2 to be long, string given .. mb_substr() expects parameter 2 to be long, string given Ad

<    1   2   3   4   5   6   7   8   9   10   >