[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix a typo in an error message in TermChangeOpSerializationV...

2017-02-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338736 ) Change subject: Fix a typo in an error message in TermChangeOpSerializationValidator .. Fix a typo in an error message in TermChangeOpS

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add simple unit test for WikibaseRepo::getTermValidatorFactory

2017-02-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338755 ) Change subject: Add simple unit test for WikibaseRepo::getTermValidatorFactory .. Add simple unit test for WikibaseRepo::getTermValidato

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Use MediaWiki's PSR-4 autoloader

2017-12-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398010 ) Change subject: [WIP] Use MediaWiki's PSR-4 autoloader .. [WIP] Use MediaWiki's PSR-4 autoloader TODO: finish + ticket! Change-Id: Id4

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Adapt JS statement revision data to allow saving statement o...

2017-12-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398496 ) Change subject: Adapt JS statement revision data to allow saving statement on forms .. Adapt JS statement revision data to allow saving

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Deserialize form-level statement data

2017-12-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398844 ) Change subject: Deserialize form-level statement data .. Deserialize form-level statement data Bug: T180467 Change-Id: I2e54cc5dc600378

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add dummy EntityHandler for Forms

2017-12-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398843 ) Change subject: Add dummy EntityHandler for Forms .. Add dummy EntityHandler for Forms Does nothing, but declaration of such services i

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Adjust AddFormTest to use new Revision framework from Media ...

2017-12-19 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399144 ) Change subject: Adjust AddFormTest to use new Revision framework from Media Wiki core .. Adjust AddFormTest to use new Revision framewo

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Autoload composer-installed dependencies

2017-12-19 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399172 ) Change subject: Autoload composer-installed dependencies .. Autoload composer-installed dependencies Change-Id: Ibacb49b3d80eaa00d4920e

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaBadges[master]: Use PSR-4 autloader from MediaWiki

2017-12-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399353 ) Change subject: Use PSR-4 autloader from MediaWiki .. Use PSR-4 autloader from MediaWiki Bug: T183260 Change-Id: I3f53ccd7cc91e75923245

[MediaWiki-commits] [Gerrit] operations/puppet[production]: phragile: Allow .htaccess needed by the app

2017-10-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382467 ) Change subject: phragile: Allow .htaccess needed by the app .. phragile: Allow .htaccess needed by the app Phragile relies on "beautifu

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: [WIP] Run QUnit tests with karma

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383603 ) Change subject: [WIP] Run QUnit tests with karma .. [WIP] Run QUnit tests with karma Bug: TODO add Change-Id: I6ab5fe1b9df8ad6cfd208029

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Switch from setup/teardown to before/afterEach in QUnit tests

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383786 ) Change subject: Switch from setup/teardown to before/afterEach in QUnit tests .. Switch from setup/teardown to before/afterEach in QUnit

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Release 0.21.0

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383787 ) Change subject: Release 0.21.0 .. Release 0.21.0 Change-Id: I4fc3241238b7ba6911aa8463c249056cb5cef94f --- M RELEASE-NOTES.md 1 file cha

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Do not use messages from View-specific dependency in HtmlTim...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385432 ) Change subject: Do not use messages from View-specific dependency in HtmlTimeFormatter .. Do not use messages from View-specific depend

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install wikibase js api as a git submodule, not as a compose...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385199 ) Change subject: Install wikibase js api as a git submodule, not as a composer dependency .. Install wikibase js api as a git submodule,

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install wikibase js serialization lib as a git submodule, no...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385202 ) Change subject: Install wikibase js serialization lib as a git submodule, not as a composer dependency .. Install wikibase js serializa

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install data values js lib as a git submodule, not as a comp...

2017-10-20 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385408 ) Change subject: Install data values js lib as a git submodule, not as a composer dependency .. Install data values js lib as a git subm

[MediaWiki-commits] [Gerrit] wikidata/build-resources[master]: Do not load ValueView extension

2017-10-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385791 ) Change subject: Do not load ValueView extension .. Do not load ValueView extension It is no longer an extension, but a lib, which is in

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [DNM] Check browser test

2017-10-24 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386210 ) Change subject: [DNM] Check browser test .. [DNM] Check browser test Change-Id: I565b63a69f8671056dcf7fc8d30e7faf1fd8794d --- M tests/b

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add README to devMaintence directory

2017-10-25 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386349 ) Change subject: Add README to devMaintence directory .. Add README to devMaintence directory It was intended to be added in I41f1bd1162

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add (failing) test for bug not showing labels of redirected ...

2017-09-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375355 ) Change subject: Add (failing) test for bug not showing labels of redirected entities .. Add (failing) test for bug not showing labels o

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP][DNM][TEST][GOAT] Mount JavaScript "libraries" as git s...

2017-09-01 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375399 ) Change subject: [WIP][DNM][TEST][GOAT] Mount JavaScript "libraries" as git submodules .. [WIP][DNM][TEST][GOAT] Mount JavaScript "libra

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use the EntityNamespaceLookup instance from WikibaseServices...

2017-09-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373318 ) Change subject: Use the EntityNamespaceLookup instance from WikibaseServices in Client and optionally Repo .. Use the EntityNam

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [WIP] Add a lexeme serializer for the external output

2017-09-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376720 ) Change subject: [WIP] Add a lexeme serializer for the external output .. [WIP] Add a lexeme serializer for the external output TODOs:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Temporarily allow failures of Travis PHP 5.5 lang=ru job

2018-01-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402048 ) Change subject: Temporarily allow failures of Travis PHP 5.5 lang=ru job .. Temporarily allow failures of Travis PHP 5.5 lang=ru job Th

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Run tests in PHP 7.1 and 7.2 environment on Travis

2018-01-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402351 ) Change subject: Run tests in PHP 7.1 and 7.2 environment on Travis .. Run tests in PHP 7.1 and 7.2 environment on Travis Change-Id: Ic2

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused changesDatabase property from SqlStore

2018-01-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402383 ) Change subject: Remove unused changesDatabase property from SqlStore .. Remove unused changesDatabase property from SqlStore Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Integrate repository configuration of WikibaseRepo int...

2018-01-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402386 ) Change subject: [WIP] Integrate repository configuration of WikibaseRepo into single setting .. [WIP] Integrate repository configuratio

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Get the name of "changes database" from WikibaseRepo, instea...

2018-01-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402384 ) Change subject: Get the name of "changes database" from WikibaseRepo, instead of reading from settings .. Get the name of "changes data

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Get base of concept URI of local repo from WikibaseRepo, don...

2018-01-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402385 ) Change subject: Get base of concept URI of local repo from WikibaseRepo, don't read from settings .. Get base of concept URI of local r

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM] Phan: load Data Access component files

2018-01-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402806 ) Change subject: [DNM] Phan: load Data Access component files .. [DNM] Phan: load Data Access component files Change-Id: I40e9b92c2ec13f

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Define class properties in SPARQLClient

2018-01-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402815 ) Change subject: Define class properties in SPARQLClient .. Define class properties in SPARQLClient Change-Id: Icd8994caf9bb4c00ea0f6949

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Phan: add stubs for the part of PageImages extension that Wi...

2018-01-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402821 ) Change subject: Phan: add stubs for the part of PageImages extension that Wikibase uses .. Phan: add stubs for the part of PageImages e

[MediaWiki-commits] [Gerrit] integration/config[master]: Use npm browser job for data-values/value-view

2018-01-08 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402862 ) Change subject: Use npm browser job for data-values/value-view .. Use npm browser job for data-values/value-view This repository requir

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [WIP] Add API action for editing elements of a form

2018-01-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402868 ) Change subject: [WIP] Add API action for editing elements of a form .. [WIP] Add API action for editing elements of a form TODOs: - er

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Added tests for classes related to EditFormElements API

2018-01-10 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403449 ) Change subject: Added tests for classes related to EditFormElements API .. Added tests for classes related to EditFormElements API Bug:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [WIP] Save changes to the form elements made in the UI

2018-01-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403665 ) Change subject: [WIP] Save changes to the form elements made in the UI .. [WIP] Save changes to the form elements made in the UI TODO:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add revision ID to the response of edit form elements API

2018-01-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403716 ) Change subject: Add revision ID to the response of edit form elements API .. Add revision ID to the response of edit form elements API

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Try out if waiting a bit after creating property make search...

2017-12-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399622 ) Change subject: Try out if waiting a bit after creating property make search results appear as expected .. Try out if waiting a bit aft

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused function in the browser test entity selector m...

2017-12-21 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399623 ) Change subject: Remove unused function in the browser test entity selector module .. Remove unused function in the browser test entity

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Revert "Try out if waiting a bit after creating property mak...

2017-12-21 Thread WMDE-leszek (Code Review)
Hello jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/399645 to review the following change. Change subject: Revert "Try out if waiting a bit after creating property make search results appear as expected" ...

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP][DNM] Switch to load extension using MediaWiki's extens...

2017-12-22 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399437 ) Change subject: [WIP][DNM] Switch to load extension using MediaWiki's extension registration .. [WIP][DNM] Switch to load extension usi

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use MediaWiki's PSR-4 autoloader to autoload those classes t...

2017-12-22 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399820 ) Change subject: Use MediaWiki's PSR-4 autoloader to autoload those classes that possible .. Use MediaWiki's PSR-4 autoloader to autoloa

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move is CirrusSearch installed check to setUp in StatementBo...

2018-01-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401484 ) Change subject: Move is CirrusSearch installed check to setUp in StatementBoostScoreBuilderTest .. Move is CirrusSearch installed check

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Rewrote is section collapsed tests in StatementHtmlGenerator...

2018-01-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401494 ) Change subject: Rewrote is section collapsed tests in StatementHtmlGeneratorTest .. Rewrote is section collapsed tests in StatementHtmlG

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do not "fake" form data of demo Lexemes

2018-01-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401521 ) Change subject: Do not "fake" form data of demo Lexemes .. Do not "fake" form data of demo Lexemes This is no longer needed, as all req

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Update IDs of statements on forms in convert lexeme data "ma...

2018-01-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401538 ) Change subject: Update IDs of statements on forms in convert lexeme data "maintenance" script .. Update IDs of statements on forms in c

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Revert "Do not collapse references on diffs/old revisions"

2018-01-02 Thread WMDE-leszek (Code Review)
Hello jenkins-bot, Thiemo Kreuz (WMDE), I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/401560 to review the following change. Change subject: Revert "Do not collapse references on diffs/old revisions" .

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Show references on the diff page

2018-01-02 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401695 ) Change subject: Show references on the diff page .. Show references on the diff page This is resubmitting part of commit e70e72b3f124a4

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove editable flag in EntityParserOutputGenerator

2018-01-03 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401699 ) Change subject: Remove editable flag in EntityParserOutputGenerator .. Remove editable flag in EntityParserOutputGenerator Also removes

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove unused EntityContentDataCodec from Repo's SqlStore

2017-09-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377235 ) Change subject: Remove unused EntityContentDataCodec from Repo's SqlStore .. Remove unused EntityContentDataCodec from Repo's SqlStore

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make a difference between entity serializers used to seriali...

2017-09-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377266 ) Change subject: Make a difference between entity serializers used to serialize data for storage, and to serialize it tu output to outside world

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do not represent form representation as a TermList internally

2017-09-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377300 ) Change subject: Do not represent form representation as a TermList internally .. Do not represent form representation as a TermList inte

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Run minus-x as a part of "composer test"

2017-09-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377711 ) Change subject: Run minus-x as a part of "composer test" .. Run minus-x as a part of "composer test" Minus X checks that files which ar

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add request object of AddForm API action and created it from...

2017-09-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377742 ) Change subject: Add request object of AddForm API action and created it from API params .. Add request object of AddForm API action and

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Add storage serializer instantiator callback to media info t...

2017-09-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377793 ) Change subject: Add storage serializer instantiator callback to media info type defintion .. Add storage serializer instantiator callba

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove undefined validate script from composer test

2017-09-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377963 ) Change subject: Remove undefined validate script from composer test .. Remove undefined validate script from composer test Change-Id: I

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add myself as a recipient of Travis failure notification emails

2017-09-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378002 ) Change subject: Add myself as a recipient of Travis failure notification emails .. Add myself as a recipient of Travis failure notificat

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Temporarily remove minus-x run from composer test

2017-09-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378238 ) Change subject: Temporarily remove minus-x run from composer test .. Temporarily remove minus-x run from composer test As it breaks Tra

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Do no allow AddFormRequestParserResult::getRequest be called...

2017-09-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378720 ) Change subject: Do no allow AddFormRequestParserResult::getRequest be called if there were errors .. Do no allow AddFormRequestParserRe

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Better JSON wellformedness check AddFormRequestParser

2017-09-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378721 ) Change subject: Better JSON wellformedness check AddFormRequestParser .. Better JSON wellformedness check AddFormRequestParser Change-I

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Move API-class-related unit tests not depending on MediaWiki...

2017-09-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378722 ) Change subject: Move API-class-related unit tests not depending on MediaWiki to appropriate subdir .. Move API-class-related unit tests

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Load DataTypes extension

2017-11-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391029 ) Change subject: Load DataTypes extension .. Load DataTypes extension Used to be loaded as the dependency of Wikibase. This makes it exp

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use MediaWiki autoloader

2017-11-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391034 ) Change subject: Use MediaWiki autoloader .. Use MediaWiki autoloader As long as extension registration does handle PSR-4 autoloading.

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use MediaWiki autoloader

2017-11-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391036 ) Change subject: Use MediaWiki autoloader .. Use MediaWiki autoloader As long as extension registration does handle PSR-4 autoloading.

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move over DataTypesModule from the former "DataTypes" extension

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391175 ) Change subject: Move over DataTypesModule from the former "DataTypes" extension .. Move over DataTypesModule from the former "DataTypes"

[MediaWiki-commits] [Gerrit] mediawiki...DataTypes[master]: Remove DataTypesModule class and other MediaWiki integration...

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391178 ) Change subject: Remove DataTypesModule class and other MediaWiki integration files .. Remove DataTypesModule class and other MediaWiki

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Install JS part of DataTypes library as a git submodule

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391191 ) Change subject: Install JS part of DataTypes library as a git submodule .. Install JS part of DataTypes library as a git submodule Bug:

[MediaWiki-commits] [Gerrit] mediawiki...DataTypes[master]: Release 2.0.0

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391196 ) Change subject: Release 2.0.0 .. Release 2.0.0 Change-Id: I2994ce9cd0f454c9d233c8086f4ce7f7394bf94b --- M README.md 1 file changed, 1 i

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Test integrity of autoload files on composer test

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391248 ) Change subject: Test integrity of autoload files on composer test .. Test integrity of autoload files on composer test Change-Id: If895

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Autoload SpecialNewEntityTest

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391250 ) Change subject: Autoload SpecialNewEntityTest .. Autoload SpecialNewEntityTest Change-Id: Ie3c508e52d024814662ab796c71e141cda701c9f ---

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Autoload client class in Repo-only mode tests

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391254 ) Change subject: Autoload client class in Repo-only mode tests .. Autoload client class in Repo-only mode tests LabelPrefetchHookHandler

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Really autoload client class in Repo-only mode tests

2017-11-14 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391510 ) Change subject: Really autoload client class in Repo-only mode tests .. Really autoload client class in Repo-only mode tests Doing Ic3c

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Break autoload test

2017-11-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391512 ) Change subject: Break autoload test .. Break autoload test Change-Id: I3eb74b65608ef899e3b3e6ba5f8acf87853c15df --- M repo/autoload.php

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Autoload EntityHandlerTest

2017-11-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391803 ) Change subject: Autoload EntityHandlerTest .. Autoload EntityHandlerTest Change-Id: I0f5267a14d076b8bf7fa79391dbff7c4b1c67efd --- M bui

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Skip provideGetUndoContent when entity does not contain "lab...

2017-11-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391832 ) Change subject: Skip provideGetUndoContent when entity does not contain "labels" .. Skip provideGetUndoContent when entity does not cont

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [DNM] Fix broken LexemeHandler tests

2017-11-16 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391862 ) Change subject: [DNM] Fix broken LexemeHandler tests .. [DNM] Fix broken LexemeHandler tests If this passes, the this and two parent pa

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Run UnDeserializableValueTests with other QUnit tests.

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383848 ) Change subject: Run UnDeserializableValueTests with other QUnit tests. .. Run UnDeserializableValueTests with other QUnit tests. Also i

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Do not run QUnit tests using MediaWiki test runner

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383853 ) Change subject: Do not run QUnit tests using MediaWiki test runner .. Do not run QUnit tests using MediaWiki test runner This is going

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Rename soon-to-come npm package

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383855 ) Change subject: Rename soon-to-come npm package .. Rename soon-to-come npm package Bug: T177816 Change-Id: Id39e3cf518823f990d7ce26d767

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Copy over some package information from composer.json to pac...

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383854 ) Change subject: Copy over some package information from composer.json to package.json\ .. Copy over some package information from compo

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Install wikibase data-values dependencies using npm not comp...

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383856 ) Change subject: Install wikibase data-values dependencies using npm not composer .. Install wikibase data-values dependencies using npm

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Remove MediaWiki ResourceLoader module definitions

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383863 ) Change subject: Remove MediaWiki ResourceLoader module definitions .. Remove MediaWiki ResourceLoader module definitions Bug: 177816 Ch

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Removed PHPCS config

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383862 ) Change subject: Removed PHPCS config .. Removed PHPCS config Change-Id: I4d8b9a89bd28d83ff3d5c5c334dee0e924c7f080 --- D phpcs.xml 1 fil

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Remove Composer files

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383861 ) Change subject: Remove Composer files .. Remove Composer files Bug: T117816 Change-Id: I77614fde38e24447a1af4304c0fed1beaabe5b9e --- M

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Release 0.22.0

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383867 ) Change subject: Release 0.22.0 .. Release 0.22.0 Bug: T177816 Change-Id: I3291ae62671e4fa82fe4ed67aa3cafa5375e459c --- M RELEASE-NOTES.

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Fix Travis CI config and use Node/JS environment on Travis CI

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383866 ) Change subject: Fix Travis CI config and use Node/JS environment on Travis CI .. Fix Travis CI config and use Node/JS environment on Tra

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Updated release notes for the upcoming release

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383865 ) Change subject: Updated release notes for the upcoming release .. Updated release notes for the upcoming release Bug: T177816 Change-Id

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Remove remaining MediaWiki integration files

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383864 ) Change subject: Remove remaining MediaWiki integration files .. Remove remaining MediaWiki integration files Bug: T177816 Change-Id: Id

[MediaWiki-commits] [Gerrit] integration/config[master]: Only run npm job for changes in data-values/value-view

2017-10-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383872 ) Change subject: Only run npm job for changes in data-values/value-view .. Only run npm job for changes in data-values/value-view Bug: T

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed not used jshint config file

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384011 ) Change subject: Removed not used jshint config file .. Removed not used jshint config file Change-Id: Ia10738e6c7089b37fcb8362d5a0df0fa

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Run QUnit tests with karma runner

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384012 ) Change subject: Run QUnit tests with karma runner .. Run QUnit tests with karma runner This all is still far from perfect. Not all code

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Do not run QUnit tests using MediaWiki runner

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384017 ) Change subject: Do not run QUnit tests using MediaWiki runner .. Do not run QUnit tests using MediaWiki runner This is going to become

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Gave the upcoming npm package npm, and copied some package i...

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384018 ) Change subject: Gave the upcoming npm package npm, and copied some package information from composer.json .. Gave the upcoming npm pack

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Updated README

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384024 ) Change subject: Updated README .. Updated README Bug: T178088 Change-Id: I474cd4788a7dc63a08af87cc7b635ea355cd8499 --- M README.md 1 fi

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed remaining MediaWiki integration files

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384023 ) Change subject: Removed remaining MediaWiki integration files .. Removed remaining MediaWiki integration files Bug: T178088 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed MediaWiki ResourceLoader module definitions

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384022 ) Change subject: Removed MediaWiki ResourceLoader module definitions .. Removed MediaWiki ResourceLoader module definitions Bug: T178088

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Install wikibase-data-values dependency using npm, not with ...

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384019 ) Change subject: Install wikibase-data-values dependency using npm, not with Composer .. Install wikibase-data-values dependency using n

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Remove PHPCS config

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384021 ) Change subject: Remove PHPCS config .. Remove PHPCS config Change-Id: I4df989ea68d7299a95867ef987466e6f6fc8ee49 --- D phpcs.xml 1 file

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseJavaScriptApi[master]: Removed Composer files

2017-10-13 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384020 ) Change subject: Removed Composer files .. Removed Composer files Bug: T178088 Change-Id: Ib148caa762a11484dee48fedb3f39c779997930d ---

<    1   2   3   4   5   6   >