Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/296184
Change subject: Remove ResourceLoaderModule methods that were deprecated in 1.26 ...................................................................... Remove ResourceLoaderModule methods that were deprecated in 1.26 Removed: - ResourceLoaderModule::getModifiedTime - ResourceLoaderModule::getModifiedHash - ResourceLoaderModule::getHashMtime - ResourceLoaderModule::getDefinitionMtime No usage @wikimedia on GitHub. Change-Id: I1dd0b8892b5896c147f81ec5ffb41f5f0dc7ae4c --- M includes/resourceloader/ResourceLoaderModule.php 1 file changed, 0 insertions(+), 57 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/84/296184/1 diff --git a/includes/resourceloader/ResourceLoaderModule.php b/includes/resourceloader/ResourceLoaderModule.php index 121a6c9..3091279 100644 --- a/includes/resourceloader/ResourceLoaderModule.php +++ b/includes/resourceloader/ResourceLoaderModule.php @@ -782,63 +782,6 @@ } /** - * Get this module's last modification timestamp for a given context. - * - * @deprecated since 1.26 Use getDefinitionSummary() instead - * @param ResourceLoaderContext $context Context object - * @return int|null UNIX timestamp - */ - public function getModifiedTime( ResourceLoaderContext $context ) { - return null; - } - - /** - * Helper method for providing a version hash to getVersionHash(). - * - * @deprecated since 1.26 Use getDefinitionSummary() instead - * @param ResourceLoaderContext $context - * @return string|null Hash - */ - public function getModifiedHash( ResourceLoaderContext $context ) { - return null; - } - - /** - * Back-compat dummy for old subclass implementations of getModifiedTime(). - * - * This method used to use ObjectCache to track when a hash was first seen. That principle - * stems from a time that ResourceLoader could only identify module versions by timestamp. - * That is no longer the case. Use getDefinitionSummary() directly. - * - * @deprecated since 1.26 Superseded by getVersionHash() - * @param ResourceLoaderContext $context - * @return int UNIX timestamp - */ - public function getHashMtime( ResourceLoaderContext $context ) { - if ( !is_string( $this->getModifiedHash( $context ) ) ) { - return 1; - } - // Dummy that is > 1 - return 2; - } - - /** - * Back-compat dummy for old subclass implementations of getModifiedTime(). - * - * @since 1.23 - * @deprecated since 1.26 Superseded by getVersionHash() - * @param ResourceLoaderContext $context - * @return int UNIX timestamp - */ - public function getDefinitionMtime( ResourceLoaderContext $context ) { - if ( $this->getDefinitionSummary( $context ) === null ) { - return 1; - } - // Dummy that is > 1 - return 2; - } - - /** * Check whether this module is known to be empty. If a child class * has an easy and cheap way to determine that this module is * definitely going to be empty, it should override this method to -- To view, visit https://gerrit.wikimedia.org/r/296184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1dd0b8892b5896c147f81ec5ffb41f5f0dc7ae4c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits