Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/314291

Change subject: CachingSiteStore: store site list using global key
......................................................................

CachingSiteStore: store site list using global key

As best as I can determine, the site list does not vary by anything
wiki-specific, so it can be made global, to save space in APC.

Change-Id: Ifd76fbe7d7cca625277026b4cd6e0dafb2004159
---
M includes/site/CachingSiteStore.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/91/314291/1

diff --git a/includes/site/CachingSiteStore.php 
b/includes/site/CachingSiteStore.php
index a2f43f3..c873933 100644
--- a/includes/site/CachingSiteStore.php
+++ b/includes/site/CachingSiteStore.php
@@ -89,8 +89,8 @@
         */
        private function getCacheKey() {
                if ( $this->cacheKey === null ) {
-                       $type = 'SiteList#' . SiteList::getSerialVersionId();
-                       $this->cacheKey = wfMemcKey( "sites/$type" );
+                       $this->cacheKey = $this->cache->makeGlobalKey(
+                               'SiteList', SiteList::getSerialVersionId() );
                }
 
                return $this->cacheKey;

-- 
To view, visit https://gerrit.wikimedia.org/r/314291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd76fbe7d7cca625277026b4cd6e0dafb2004159
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to