https://www.mediawiki.org/wiki/Special:Code/MediaWiki/103016
Revision: 103016 Author: tparscal Date: 2011-11-14 19:51:00 +0000 (Mon, 14 Nov 2011) Log Message: ----------- Using splice.apply because it's faster and actually works (the loop was incorrect anyways) Modified Paths: -------------- trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js Modified: trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js =================================================================== --- trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js 2011-11-14 19:50:28 UTC (rev 103015) +++ trunk/extensions/VisualEditor/modules/es/models/es.DocumentModel.js 2011-11-14 19:51:00 UTC (rev 103016) @@ -78,9 +78,7 @@ // Regenerate nodes for the data we've affected var newNodes = es.DocumentModel.createNodesFromData( newData ); // Insert new elements into the tree where the old ones used to be - for ( var i = newNodes.length - 1; i >= 0; i-- ) { - parent.splice( index, 0, newNodes[i] ); - } + parent.splice.apply( parent, [index, 0].concat( newNodes ) ); } function insert( op ) { _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs