https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114217

Revision: 114217
Author:   qchris
Date:     2012-03-19 23:36:48 +0000 (Mon, 19 Mar 2012)
Log Message:
-----------
Follow up to r114126: Being more conservative for HipHop compiler

Modified Paths:
--------------
    trunk/phase3/includes/parser/Preprocessor_HipHop.hphp

Modified: trunk/phase3/includes/parser/Preprocessor_HipHop.hphp
===================================================================
--- trunk/phase3/includes/parser/Preprocessor_HipHop.hphp       2012-03-19 
23:33:57 UTC (rev 114216)
+++ trunk/phase3/includes/parser/Preprocessor_HipHop.hphp       2012-03-19 
23:36:48 UTC (rev 114217)
@@ -444,7 +444,8 @@
                        } elseif ( $found === 'line-end' ) {
                                $piece = $stack->getTop();
                                // A heading must be open, otherwise \n 
wouldn't have been in the search list
-                               assert( '$piece->open === "\n"' );
+                               assert( $piece->open === "\n" ); // Passing the 
assert condition directly instead of string, as
+                                                                // HPHP 
/compiler/ chokes on strings when ASSERT_ACTIVE != 0.
                                $part = $piece->getCurrentPart();
                                // Search back through the input to see if it 
has a proper close
                                // Do this using the reversed string since the 
other solutions (end anchor, etc.) are inefficient


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to