Revision: 51670
Author: tparscal
Date: 2009-06-10 00:01:22 +0000 (Wed, 10 Jun 2009)
Log Message:
-----------
Solved some issues with how browsers were handling the onbeforeunload event
Modified Paths:
--------------
trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.i18n.php
trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
Modified: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.i18n.php
===================================================================
--- trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.i18n.php
2009-06-09 23:59:42 UTC (rev 51669)
+++ trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.i18n.php
2009-06-10 00:01:22 UTC (rev 51670)
@@ -14,5 +14,5 @@
$messages['en'] = array(
'editwarning' => 'Edit warning',
'editwarning-desc' => 'Show a warning when a user tries to leave the
edit form without saving',
- 'editwarning-warning' => 'You have unsaved changes. Click OK to leave
this page and abandon your changes, or Cancel to stay here and keep them.',
+ 'editwarning-warning' => 'Leaving this page will cause you to loose any
changes you have made.',
);
Modified: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
===================================================================
--- trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
2009-06-09 23:59:42 UTC (rev 51669)
+++ trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
2009-06-10 00:01:22 UTC (rev 51670)
@@ -3,18 +3,14 @@
$( document ).ready( function() {
$( 'textarea#wpTextbox1, input#wpSummary' )
.bind(
- 'change select paste cut',
+ 'change select paste cut keydown',
function () {
- $( window ).bind(
- 'beforeunload',
- function( event ) {
- if( !confirm(
gM('editwarning-warning' ) ) ) {
- event.preventDefault();
- }
-
event.stopImmediatePropagation();
+ if ( !( 'onbeforeunload' in window ) ) {
+ window.onbeforeunload = function() {
+ return gM('editwarning-warning'
);
}
- );
+ }
}
);
}
-);
+);
\ No newline at end of file
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
