Revision: 52124
Author: aaron
Date: 2009-06-18 17:03:34 +0000 (Thu, 18 Jun 2009)
Log Message:
-----------
(bug 19192) Make review failure more obvious in UI
Modified Paths:
--------------
trunk/extensions/FlaggedRevs/flaggedrevs.js
trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
Modified: trunk/extensions/FlaggedRevs/flaggedrevs.js
===================================================================
--- trunk/extensions/FlaggedRevs/flaggedrevs.js 2009-06-18 17:01:17 UTC (rev
52123)
+++ trunk/extensions/FlaggedRevs/flaggedrevs.js 2009-06-18 17:03:34 UTC (rev
52124)
@@ -234,7 +234,8 @@
if( typeof wgAjaxReview === "undefined" || !wgAjaxReview ) {
wgAjaxReview = {
sendingMsg: "Submitting...",
- sentMsg: "Submitted",
+ sentMsgOk: "Review complete!",
+ sentMsgBad: "Review failed!",
actioncomplete: "Action complete",
actionfailed: "Action failed"
};
@@ -336,9 +337,11 @@
return;
}
var response = request.responseText;
+ var success = false;
if( msg = response.substr(6) ) {
jsMsg( msg, 'review' );
window.scroll(0,0);
+ success = true;
}
wgAjaxReview.inprogress = false;
if( wgAjaxReview.timeoutID ) {
@@ -346,7 +349,10 @@
}
var submit = document.getElementById("submitreview");
if( submit ) {
- submit.value = wgAjaxReview.sentMsg;
+ if( success )
+ submit.value = wgAjaxReview.sentMsgOk;
+ else
+ submit.value = wgAjaxReview.sentMsgBad;
}
if( response.indexOf('<suc#>') == 0 ) {
wgAjaxReview.unlockForm();
Modified: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
===================================================================
--- trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php 2009-06-18
17:01:17 UTC (rev 52123)
+++ trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php 2009-06-18
17:03:34 UTC (rev 52124)
@@ -145,8 +145,9 @@
'revreview-style-3' => 'Concise',
'revreview-style-4' => 'Featured',
'revreview-submit' => 'Submit',
- 'revreview-submitting' => 'Submitting …',
+ 'revreview-submitting' => 'Submitting...',
'revreview-finished' => 'Review complete!',
+ 'revreview-failed' => 'Review failed!',
'revreview-successful' => '\'\'\'Revision of [[:$1|$1]]
successfully flagged. ([{{fullurl:Special:Stableversions|page=$2}} view stable
versions])\'\'\'',
'revreview-successful2' => '\'\'\'Revision of [[:$1|$1]]
successfully unflagged.\'\'\'',
'revreview-text' =>
'\'\'[[{{MediaWiki:Validationpage}}|Stable versions]] are the default page
content for viewers rather than the newest revision.\'\'',
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
