http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58842
Revision: 58842 Author: siebrand Date: 2009-11-09 21:43:33 +0000 (Mon, 09 Nov 2009) Log Message: ----------- Add a bunch of FIXMEs for bad i18n Modified Paths: -------------- trunk/extensions/QPoll/qp_results.php Modified: trunk/extensions/QPoll/qp_results.php =================================================================== --- trunk/extensions/QPoll/qp_results.php 2009-11-09 21:43:12 UTC (rev 58841) +++ trunk/extensions/QPoll/qp_results.php 2009-11-09 21:43:33 UTC (rev 58842) @@ -659,7 +659,9 @@ $pagename = htmlspecialchars( $wgContLang->convert( $poll_title->getPrefixedText() ) ); $pollname = htmlspecialchars( $result->poll_id ); $goto_link = self::$skin->link( $poll_title, wfMsg( 'qp_source_link' ) ); + // FIXME: This is a lot of hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $voice_link = self::$skin->link( $this->getTitle(), wfMsg( 'qp_voice_link' ) . ( $this->inverse ? "?" : "" ), array(), array( "id"=>intval( $result->pid), "uid"=>$this->uid, "action"=>"uvote" ) ); + // FIXME: This is a lot of hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $link = wfMsg( 'qp_spec_line', '"' . $pagename . '"', '"' . $pollname . '":' , $voice_link, '', '', '' ); return $link; } @@ -777,7 +779,9 @@ $userName = $result->username; $userTitle = Title::makeTitleSafe( NS_USER, $userName ); $user_link = self::$skin->link( $userTitle, $userName ); + // FIXME: This is a lot of hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $voice_link = self::$skin->link( $this->getTitle(), wfMsg( 'qp_voice_link' ) . ( $this->inverse ? "?" : "" ), array(), array( "id"=>intval( $this->pid), "uid"=>$uid, "action"=>"uvote" ) ); + // FIXME: This is hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $link = $user_link . ': ' . $voice_link; } return $link; @@ -891,8 +895,10 @@ $userName = $result->username; $userTitle = Title::makeTitleSafe( NS_USER, $userName ); $user_link = self::$skin->link( $userTitle, $userName ); + // FIXME: This is a lot of hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $voice_link = self::$skin->link( $this->getTitle(), wfMsg( 'qp_voice_link' ) . ( $this->inverse ? "?" : "" ), array(), array( "id"=>intval( $this->pid), "uid"=>$uid, "action"=>"uvote" ) ); $text_answer = ($result->text_answer == '') ? '' : ' <i>' . htmlentities( $result->text_answer ) . '</i>'; + // FIXME: This is hard coded formatting. Please make a message with parameters for this, as not all languages would format this in this same way. $link = $user_link . ': ' . $voice_link . $text_answer; } return $link; _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs