http://www.mediawiki.org/wiki/Special:Code/MediaWiki/61901
Revision: 61901 Author: mah Date: 2010-02-03 02:19:25 +0000 (Wed, 03 Feb 2010) Log Message: ----------- follow up r61779 - anyone who writes "!$x == null" is an idiot Modified Paths: -------------- trunk/phase3/includes/upload/UploadFromChunks.php Modified: trunk/phase3/includes/upload/UploadFromChunks.php =================================================================== --- trunk/phase3/includes/upload/UploadFromChunks.php 2010-02-03 00:49:33 UTC (rev 61900) +++ trunk/phase3/includes/upload/UploadFromChunks.php 2010-02-03 02:19:25 UTC (rev 61901) @@ -38,7 +38,7 @@ } public function initialize( $done, $filename, $sessionKey, $path, - $fileSize, $sessionData ) + $fileSize, $sessionData ) { $this->initFromSessionKey( $sessionKey, $sessionData ); @@ -90,14 +90,14 @@ protected function initFromSessionKey( $sessionKey, $sessionData ) { // testing against null because we don't want to cause obscure // bugs when $sessionKey is full of "0" - if ( !$sessionKey === null ) { + if ( $sessionKey !== null ) { $this->status = Status::newFromFatal( 'import-token-mismatch' ); return; } $this->sessionKey = $sessionKey; if ( isset( $sessionData[$this->sessionKey]['version'] ) - && $sessionData[$this->sessionKey]['version'] == self::SESSION_VERSION ) + && $sessionData[$this->sessionKey]['version'] == self::SESSION_VERSION ) { $this->comment = $sessionData[$this->sessionKey]['comment']; $this->pageText = $sessionData[$this->sessionKey]['pageText']; @@ -211,7 +211,7 @@ } else { $this->status = Status::newFatal( 'filenotfound', $this->repoPath ); } - if ( $this->fileSize > $wgMaxUploadSize ) + if ( $this->fileSize > $wgMaxUploadSize ) $this->status = Status::newFatal( 'largefileserver' ); } _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs