http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65040
Revision: 65040
Author: happy-melon
Date: 2010-04-14 21:42:37 +0000 (Wed, 14 Apr 2010)
Log Message:
-----------
>From r64866, more consistent behaviour of hidden field names. May affect
>r65029.
Modified Paths:
--------------
trunk/phase3/includes/HTMLForm.php
Modified: trunk/phase3/includes/HTMLForm.php
===================================================================
--- trunk/phase3/includes/HTMLForm.php 2010-04-14 21:22:38 UTC (rev 65039)
+++ trunk/phase3/includes/HTMLForm.php 2010-04-14 21:42:37 UTC (rev 65040)
@@ -305,7 +305,8 @@
* @param $attribs Array
*/
public function addHiddenField( $name, $value, $attribs=array() ){
- $this->mHiddenFields[ $name ] = array( $value, $attribs );
+ $attribs += array( 'name' => $name );
+ $this->mHiddenFields[] = array( $value, $attribs );
}
public function addButton( $name, $value, $id=null, $attribs=null ){
@@ -377,9 +378,9 @@
$html .= Html::hidden( 'wpEditToken', $wgUser->editToken(),
array( 'id' => 'wpEditToken' ) ) . "\n";
$html .= Html::hidden( 'title',
$this->getTitle()->getPrefixedText() ) . "\n";
- foreach( $this->mHiddenFields as $name => $value ){
- list( $value, $attribs ) = $value;
- $html .= Html::hidden( $name, $value, $attribs ) . "\n";
+ foreach( $this->mHiddenFields as $data ){
+ list( $value, $attribs ) = $data;
+ $html .= Html::hidden( $attribs['name'], $value,
$attribs ) . "\n";
}
return $html;
@@ -1397,6 +1398,13 @@
class HTMLHiddenField extends HTMLFormField {
+ public function __construct( $params ){
+ parent::__construct( $params );
+ # forcing the 'wp' prefix on hidden field names
+ # is undesirable
+ $this->mName = substr( $this->mName, 2 );
+ }
+
public function getTableRow( $value ){
$params = array();
if( $this->mID ){
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
