http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65621
Revision: 65621
Author: maxsem
Date: 2010-04-28 18:12:42 +0000 (Wed, 28 Apr 2010)
Log Message:
-----------
Marked Database::newFromParams() as deprecated, cleaned up a few mysqlisms in
comments
Modified Paths:
--------------
trunk/phase3/includes/db/Database.php
Modified: trunk/phase3/includes/db/Database.php
===================================================================
--- trunk/phase3/includes/db/Database.php 2010-04-28 18:01:56 UTC (rev
65620)
+++ trunk/phase3/includes/db/Database.php 2010-04-28 18:12:42 UTC (rev
65621)
@@ -353,6 +353,7 @@
*/
static function newFromParams( $server, $user, $password, $dbName,
$failFunction = false, $flags = 0 )
{
+ wfDeprecated( __METHOD__ );
return new DatabaseMysql( $server, $user, $password, $dbName,
$failFunction, $flags );
}
@@ -402,7 +403,7 @@
}
/**
- * @param $error String: fallback error message, used if none is given
by MySQL
+ * @param $error String: fallback error message, used if none is given
by DB
*/
function reportConnectionError( $error = 'Unknown error' ) {
$myError = $this->lastError();
@@ -595,7 +596,7 @@
}
function freePrepared( $prepared ) {
- /* No-op for MySQL */
+ /* No-op by default */
}
/**
@@ -687,7 +688,7 @@
* member variables.
*
* @param $res SQL result object as returned from Database::query(),
etc.
- * @return MySQL row object
+ * @return Row object
* @throws DBUnexpectedError Thrown if the database returns an error
*/
abstract function fetchObject( $res );
@@ -697,7 +698,7 @@
* form. Fields are retrieved with $row['fieldname'].
*
* @param $res SQL result object as returned from Database::query(),
etc.
- * @return MySQL row object
+ * @return Row object
* @throws DBUnexpectedError Thrown if the database returns an error
*/
abstract function fetchRow( $res );
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
