http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65648
Revision: 65648
Author: jeroendedauw
Date: 2010-04-28 23:37:33 +0000 (Wed, 28 Apr 2010)
Log Message:
-----------
Fixed style for validation errors
Modified Paths:
--------------
trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php
trunk/extensions/Storyboard/storyboard.css
trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
Modified:
trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php
===================================================================
---
trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php
2010-04-28 23:24:52 UTC (rev 65647)
+++
trunk/extensions/Storyboard/specials/StorySubmission/StorySubmission_body.php
2010-04-28 23:37:33 UTC (rev 65648)
@@ -83,7 +83,11 @@
$wgOut->setPageTitle( wfMsg(
'storyboard-submissionincomplete' ) );
$wgOut->addWikiMsg( 'storyboard-alreadyexists', $title,
$wgTitle->getFullURL() );
- $wgOut->addHtml( '<a href="#" onclick="history.go(-1);
return false;">' . wfMsg( 'storyboard-changetitle' ) . '</a>' );
+
+ // Let's not give a null link to people with no JS.
+ // TODO: change this to the last page somehow
+ $fallBackUrl = Title::newMainPage()->getFullURL();
+ $wgOut->addHtml( "<a href='$fallBackUrl'
onclick='history.go(-1); return false;'>" . wfMsg( 'storyboard-changetitle' ) .
'</a>' );
}
}
Modified: trunk/extensions/Storyboard/storyboard.css
===================================================================
--- trunk/extensions/Storyboard/storyboard.css 2010-04-28 23:24:52 UTC (rev
65647)
+++ trunk/extensions/Storyboard/storyboard.css 2010-04-28 23:37:33 UTC (rev
65648)
@@ -64,11 +64,15 @@
float: right;
}
+.validationerror {
+ color: red;
+}
+
/**
* Css for <storyboard> tags
*/
.storyboard {
-border: 1px solid #ddd;
+ border: 1px solid #ddd;
}
.storyboard .storyboard-batch {
margin: 0;
Modified:
trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
===================================================================
--- trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
2010-04-28 23:24:52 UTC (rev 65647)
+++ trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
2010-04-28 23:37:33 UTC (rev 65648)
@@ -27,8 +27,6 @@
* @param $frame
*
* @return array
- *
- * FIXME: the submission broke somehow
*/
public static function render( $input, array $args, Parser $parser,
$frame ) {
wfProfileIn( __METHOD__ );
@@ -213,15 +211,13 @@
$formBody .= Html::hidden( 'lang', $args['language'] );
- $submissionUrl = SpecialPage::getTitleFor( 'StorySubmission'
)->getFullURL();
-
return Html::rawElement(
'form',
array(
'id' => 'storyform',
'name' => 'storyform',
'method' => 'post',
- 'action' => $submissionUrl,
+ 'action' => SpecialPage::getTitleFor(
'StorySubmission' )->getFullURL(),
'onsubmit' => 'return stbValidateSubmission(
"storyboard-agreement" );'
),
$formBody
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
