http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70586

Revision: 70586
Author:   reedy
Date:     2010-08-06 19:17:45 +0000 (Fri, 06 Aug 2010)

Log Message:
-----------
If the user can't retrieve email, theres no point getting their lang!

Modified Paths:
--------------
    trunk/extensions/CodeReview/backend/CodeRevision.php

Modified: trunk/extensions/CodeReview/backend/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/backend/CodeRevision.php        2010-08-06 
19:07:56 UTC (rev 70585)
+++ trunk/extensions/CodeReview/backend/CodeRevision.php        2010-08-06 
19:17:45 UTC (rev 70586)
@@ -399,14 +399,17 @@
                        $title = SpecialPage::getTitleFor( 'Code', 
$this->mRepo->getName() . '/' . $this->mId );
                        $title->setFragment( "#c{$commentId}" );
                        $url = $title->getFullUrl();
+
                        foreach ( $users as $userId => $user ) {
                                // No sense in notifying this commenter
                                if ( $wgUser->getId() == $user->getId() ) {
                                        continue;
                                }
-                               // Send message in receiver's language
-                               $lang = array( 'language' => $user->getOption( 
'language' ) );
+
                                if ( $user->canReceiveEmail() ) {
+                                       // Send message in receiver's language
+                                       $lang = array( 'language' => 
$user->getOption( 'language' ) );
+                               
                                        $user->sendMail(
                                                wfMsgExt( 
'codereview-email-subj', $lang, $this->mRepo->getName(), $this->getIdString() ),
                                                wfMsgExt( 
'codereview-email-body', $lang, $wgUser->getName(), $url, 
$this->getIdStringUnique(), $text )



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to