http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71100

Revision: 71100
Author:   ialex
Date:     2010-08-15 07:25:33 +0000 (Sun, 15 Aug 2010)

Log Message:
-----------
* SpecialPage::getTitleFor() is a static method; use SpecialPage::getTitle() 
which is dynamic and doesn't require page's name
* wfMsg() -> wfMsgHtml() for the text passed to Linker::link() since it won't 
be escaped by the latter method

Modified Paths:
--------------
    trunk/extensions/MWReleases/ui/SpecialReleaseManager.php

Modified: trunk/extensions/MWReleases/ui/SpecialReleaseManager.php
===================================================================
--- trunk/extensions/MWReleases/ui/SpecialReleaseManager.php    2010-08-15 
07:16:58 UTC (rev 71099)
+++ trunk/extensions/MWReleases/ui/SpecialReleaseManager.php    2010-08-15 
07:25:33 UTC (rev 71100)
@@ -56,8 +56,8 @@
                $this->out->addWikiMsg( 'releasemanager-header' );
                $h = Html::openElement( 'div', array( 'style' => 
'text-align:center' ) ) .
                        $this->skin->link(
-                               $this->getTitleFor( 'ReleaseManager', 'add' ),
-                               wfMsg( 'releasemanager-add' ),
+                               $this->getTitle( 'add' ),
+                               wfMsgHtml( 'releasemanager-add' ),
                                array( 'style' => 'font-size:175%' )
                        ) . Html::element( 'hr' ) . Html::closeElement( 'div' ) 
.
                        Html::openElement( 'table', array( 'class' => 
'wikitable plainlinks sortable' ) ) .
@@ -86,11 +86,11 @@
                        wfMsg( 'releasemanager-supported-overriden', $supported 
) :
                        wfMsg( 'releasemanager-supported-til-eol', $supported );
                $editDel = $this->skin->link(
-                       $this->getTitleFor( 'ReleaseManager', 'edit/' . 
$rel->getId() ),
-                       wfMsg( 'edit' )
+                       $this->getTitle( 'edit/' . $rel->getId() ),
+                       wfMsgHtml( 'edit' )
                ) . ' / ' . $this->skin->link(
-                       $this->getTitleFor( 'ReleaseManager', 'delete/' . 
$rel->getId() ),
-                       wfMsg( 'delete' )
+                       $this->getTitle( 'delete/' . $rel->getId() ),
+                       wfMsgHtml( 'delete' )
                );
                return Html::openElement( 'tr' ) .
                        Html::element( 'td', array(), $rel->getName() ) .
@@ -123,7 +123,7 @@
                        $this->out->addWikiMsg( 'releasemanager-doesnotexist' );
                        return;
                } else {
-                       $submitUrl = $this->getTitleFor( 'ReleaseManager', 
"delete/$versionId" )->getFullURL();
+                       $submitUrl = $this->getTitle( "delete/$versionId" 
)->getFullURL();
                        $this->out->addWikiMsg( 'releasemanager-delete-confirm' 
);
                        $h = Html::openElement( 'form', array( 'action' => 
$submitUrl,
                                'method' => 'post' ) ) .



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to