http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71207

Revision: 71207
Author:   reedy
Date:     2010-08-17 18:44:07 +0000 (Tue, 17 Aug 2010)

Log Message:
-----------
*(bug 24811) Link to the revision being followed up in a followup email

Modified Paths:
--------------
    trunk/extensions/CodeReview/CodeReview.i18n.php
    trunk/extensions/CodeReview/backend/CodeRevision.php

Modified: trunk/extensions/CodeReview/CodeReview.i18n.php
===================================================================
--- trunk/extensions/CodeReview/CodeReview.i18n.php     2010-08-17 17:48:22 UTC 
(rev 71206)
+++ trunk/extensions/CodeReview/CodeReview.i18n.php     2010-08-17 18:44:07 UTC 
(rev 71207)
@@ -126,6 +126,8 @@
        'codereview-email-subj2' => '[$1] [$2]: Follow-up changes',
        'codereview-email-body2' => 'User "$1" made follow-up changes to $2.
 
+Full URL for followed up revision: $5
+
 Full URL: $3
 
 Commit summary:

Modified: trunk/extensions/CodeReview/backend/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/backend/CodeRevision.php        2010-08-17 
17:48:22 UTC (rev 71206)
+++ trunk/extensions/CodeReview/backend/CodeRevision.php        2010-08-17 
18:44:07 UTC (rev 71207)
@@ -341,6 +341,9 @@
                                $revision = CodeRevision::newFromRow( $row );
                                $users = $revision->getCommentingUsers();
                                
+                               $rowTitle = SpecialPage::getTitleFor( 'Code', 
$this->mRepo->getName() . '/' . $row->mId );
+                               $rowUrl = $rowTitle->getFullUrl();
+                               
                                $revisionAuthor = $revision->getWikiUser();
                                
                                //Add the followup revision author if they have 
not already been added as a commentor (they won't want dupe emails!)
@@ -360,7 +363,7 @@
                                                $lang = array( 'language' => 
$user->getOption( 'language' ) );
                                                $user->sendMail(
                                                        wfMsgExt( 
'codereview-email-subj2', $lang, $this->mRepo->getName(), $this->getIdString( 
$row->cr_id ) ),
-                                                       wfMsgExt( 
'codereview-email-body2', $lang, $committer, $this->getIdStringUnique( 
$row->cr_id ), $url, $this->mMessage )
+                                                       wfMsgExt( 
'codereview-email-body2', $lang, $committer, $this->getIdStringUnique( 
$row->cr_id ), $url, $this->mMessage, $rowUrl )
                                                );
                                        }
                                }



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to