http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72864
Revision: 72864 Author: catrope Date: 2010-09-12 15:15:30 +0000 (Sun, 12 Sep 2010) Log Message: ----------- (bug 24987) Special:ListUsers does not take external groups into account. Patch by Mathias Ertl Modified Paths: -------------- trunk/phase3/CREDITS trunk/phase3/RELEASE-NOTES trunk/phase3/includes/specials/SpecialListusers.php Modified: trunk/phase3/CREDITS =================================================================== --- trunk/phase3/CREDITS 2010-09-12 15:07:12 UTC (rev 72863) +++ trunk/phase3/CREDITS 2010-09-12 15:15:30 UTC (rev 72864) @@ -102,6 +102,7 @@ * Marcin Cieślak * Marcus Buck * Marooned +* Mathias Ertl * Matthew Britton * mati * Max Sikström Modified: trunk/phase3/RELEASE-NOTES =================================================================== --- trunk/phase3/RELEASE-NOTES 2010-09-12 15:07:12 UTC (rev 72863) +++ trunk/phase3/RELEASE-NOTES 2010-09-12 15:15:30 UTC (rev 72864) @@ -315,6 +315,7 @@ * (bug 6204) TOC not properly rendered when using $wgMaxTocLevel * (bug 24977) The accesskey in history page now lead directly to the diff instead of alterning focus between the two buttons. +* (bug 24987) Special:ListUsers does not take external groups into account === API changes in 1.17 === * (bug 22738) Allow filtering by action type on query=logevent. Modified: trunk/phase3/includes/specials/SpecialListusers.php =================================================================== --- trunk/phase3/includes/specials/SpecialListusers.php 2010-09-12 15:07:12 UTC (rev 72863) +++ trunk/phase3/includes/specials/SpecialListusers.php 2010-09-12 15:15:30 UTC (rev 72864) @@ -125,13 +125,12 @@ $userPage = Title::makeTitle( NS_USER, $row->user_name ); $name = $this->getSkin()->link( $userPage, htmlspecialchars( $userPage->getText() ) ); - if( $row->numgroups > 1 || ( $this->requestedGroup && $row->numgroups == 1 ) ) { + $groups_list = self::getGroups( $row->user_id ); + if( count( $groups_list ) > 0 ) { $list = array(); - foreach( self::getGroups( $row->user_id ) as $group ) + foreach( $groups_list as $group ) $list[] = self::buildGroupLink( $group ); $groups = $wgLang->commaList( $list ); - } elseif( $row->numgroups == 1 ) { - $groups = self::buildGroupLink( $row->singlegroup ); } else { $groups = ''; } _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs