http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75679
Revision: 75679
Author: reedy
Date: 2010-10-29 21:38:15 +0000 (Fri, 29 Oct 2010)
Log Message:
-----------
Case statement was falling through and assigning to the same, remove that case
and have explicit fall through
Modified Paths:
--------------
trunk/extensions/DynamicPageList/DPLLogger.php
trunk/extensions/DynamicPageList/DPLMain.php
Modified: trunk/extensions/DynamicPageList/DPLLogger.php
===================================================================
--- trunk/extensions/DynamicPageList/DPLLogger.php 2010-10-29 21:36:49 UTC
(rev 75678)
+++ trunk/extensions/DynamicPageList/DPLLogger.php 2010-10-29 21:38:15 UTC
(rev 75679)
@@ -75,7 +75,6 @@
$msgid = DPL_i18n::FATAL_WRONGLINKSTO;
break;
case 'titlemaxlength':
- $msgid = DPL_i18n::WARN_WRONGPARAM_INT;
case 'includemaxlength':
$msgid = DPL_i18n::WARN_WRONGPARAM_INT;
break;
Modified: trunk/extensions/DynamicPageList/DPLMain.php
===================================================================
--- trunk/extensions/DynamicPageList/DPLMain.php 2010-10-29 21:36:49 UTC
(rev 75678)
+++ trunk/extensions/DynamicPageList/DPLMain.php 2010-10-29 21:38:15 UTC
(rev 75679)
@@ -47,7 +47,6 @@
// Local parser created. See
http://www.mediawiki.org/wiki/Extensions_FAQ#How_do_I_render_wikitext_in_my_extension.3F
$localParser = new Parser();
$pOptions = $parser->mOptions;
- $pTitle = $parser->mTitle;
// check if DPL shall only be executed from protected pages
if ( array_key_exists( 'RunFromProtectedPagesOnly',
ExtDynamicPageList::$options ) &&
@@ -3379,7 +3378,7 @@
$aTableRow = array();
$groupNr = - 1;
$t = - 1;
- foreach ( $aSecLabels as $colgroup => $label ) {
+ foreach ( $aSecLabels as $label ) {
$t++;
$groupNr++;
$cols = split( '}:', $label );
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
