http://www.mediawiki.org/wiki/Special:Code/MediaWiki/76208
Revision: 76208 Author: catrope Date: 2010-11-06 18:52:46 +0000 (Sat, 06 Nov 2010) Log Message: ----------- 1.16wmf4: Merge CodeReview up to r74820 Modified Paths: -------------- branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.i18n.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php branches/wmf/1.16wmf4/extensions/CodeReview/svnImport.php branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeAuthorListView.php branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeReleaseNotes.php branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionListView.php Added Paths: ----------- branches/wmf/1.16wmf4/extensions/CodeReview/README Property Changed: ---------------- branches/wmf/1.16wmf4/extensions/CodeReview/ branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionView.php Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview ___________________________________________________________________ Modified: svn:mergeinfo - /trunk/extensions/CodeReview:62838-74378,74631-74632,74635,74640,74653,74659,74985,75235 + /trunk/extensions/CodeReview:62838-74821,74985,75235 Modified: branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.i18n.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.i18n.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/CodeReview.i18n.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -1298,6 +1298,7 @@ 'repoadmin-edit-view' => 'Putanja za ViewVC:', 'repoadmin-edit-button' => 'U redu', 'repoadmin-edit-sucess' => 'Repozitorijum "[[Special:Code/$1|$1]]" je uspješno promijenjen.', + 'repoadmin-nav' => 'administracija repozitorijuma', 'right-repoadmin' => 'Uređivanje repozitorijuma koda', 'right-codereview-use' => 'Korištenje Special:Code', 'right-codereview-add-tag' => 'Dodavanje novih oznaka revizijama', @@ -1422,7 +1423,7 @@ 'code-authors' => 'autoři', 'code-status' => 'stavy', 'code-tags' => 'značky', - 'code-authors-text' => 'Toto je seznam autorů v úložišti seřazený podle jména. V závorkách jsou uživatelská jména na této wiki.', + 'code-authors-text' => 'Toto je seznam autorů v úložišti seřazený podle jména. V závorkách jsou uživatelská jména na této wiki. Data mohou pocházet z cache.', 'code-author-haslink' => 'Tento autor je spojen s wiki uživatelem $1', 'code-author-orphan' => 'Tento autor není svázaný s žádným wikiuživatelem', 'code-author-dolink' => 'Svázat tohoto autora s wikiuživatelem:', @@ -1435,6 +1436,7 @@ 'code-author-unlinksuccess' => 'Vazba autora $1 byla zrušena', 'code-author-badtoken' => 'Při provádění operace došlo k chybě sezení.', 'code-author-total' => 'Celkový počet autorů: $1', + 'code-author-lastcommit' => 'Datum posledního commitu', 'code-browsing-path' => "Procházení revizemi v '''$1'''", 'code-field-id' => 'Revize', 'code-field-author' => 'Autor', @@ -1533,6 +1535,7 @@ 'repoadmin-edit-view' => 'Cesta k ViewVC:', 'repoadmin-edit-button' => 'OK', 'repoadmin-edit-sucess' => 'Úložiště „[[Special:Code/$1|$1]]“ bylo úspěšně změněno.', + 'repoadmin-nav' => 'správa úložiště', 'right-repoadmin' => 'Správa úložišť kódu', 'right-codereview-use' => 'Používání stránky {{ns:Special}}:Code', 'right-codereview-add-tag' => 'Přidávání značek k revizím', @@ -2321,6 +2324,8 @@ 'codereview-email-subj2' => '[$1] [$2]: Postatentaj ŝanĝoj', 'codereview-email-body2' => 'Uzanto "$1" faris postatentadajn ŝanĝojn al $2. +Plena URL por la postatentadaj revizio: $5 + Plena URL: $3 Resumo de ŝanĝoj: @@ -2354,6 +2359,7 @@ * @author Dferg * @author Diego Grez * @author Imre + * @author Locos epraix * @author McDutchie * @author Omnipaedista * @author Pertile @@ -2495,6 +2501,7 @@ 'repoadmin-edit-view' => 'Ruta de ViewVC:', 'repoadmin-edit-button' => 'Aceptar', 'repoadmin-edit-sucess' => 'El repositorio «[[Special:Code/$1|$1]]» ha sido modificado correctamente.', + 'repoadmin-nav' => 'administración del repositorio', 'right-repoadmin' => 'Gestionar repositorios de código', 'right-codereview-use' => 'Uso de especial:Código', 'right-codereview-add-tag' => 'Añadir nuevas etiquetas a las revisiones', @@ -2855,6 +2862,7 @@ 'repoadmin-edit-view' => 'مسیر ViewVC:', 'repoadmin-edit-button' => 'مورد تایید', 'repoadmin-edit-sucess' => 'مخزن «[[Special:Code/$1|$1]]» با موفقیت تغییر داده شد.', + 'repoadmin-nav' => 'مدیریت مخزن', 'right-repoadmin' => 'مدیریت مخازن کد', 'right-codereview-use' => 'استفاده از ویژه:کد', 'right-codereview-add-tag' => 'افزودن برچسبهای جدید به نسخهها', @@ -3032,7 +3040,7 @@ 'code-authors' => 'auteurs', 'code-status' => 'états', 'code-tags' => 'balises', - 'code-authors-text' => 'La liste ci-dessous présente les auteurs de dépôts triés par nom. Les comptes du wiki local sont affichés entre parenthèses.', + 'code-authors-text' => 'La liste ci-dessous présente les auteurs de dépôts triés par nom. Les comptes du wiki local sont affichés entre parenthèses. Les données peuvent provenir d’une mémoire tampon.', 'code-author-haslink' => 'Cet auteur est lié au compte $1 de ce wiki', 'code-author-orphan' => 'Cet auteur n’a pas de lien avec un compte wiki', 'code-author-dolink' => 'Associer cet auteur à un utilisateur wiki local :', @@ -3045,6 +3053,7 @@ 'code-author-unlinksuccess' => 'L’auteur $1 a été délié', 'code-author-badtoken' => 'Erreur de session lors de l’exécution de cette action.', 'code-author-total' => 'Nombre total d’auteurs : $1', + 'code-author-lastcommit' => 'Dernière date d’envoi', 'code-browsing-path' => "Parcours des révisions dans '''$1'''", 'code-field-id' => 'Révision', 'code-field-author' => 'Auteur', @@ -3143,6 +3152,7 @@ 'repoadmin-edit-view' => 'Chemin de ViewVC :', 'repoadmin-edit-button' => 'Valider', 'repoadmin-edit-sucess' => 'Le dépôt « [[Special:Code/$1|$1]] » a été modifié avec succès.', + 'repoadmin-nav' => 'administration du dépôt', 'right-repoadmin' => 'Administrer les dépôts de code', 'right-codereview-use' => 'Utiliser Special:Code', 'right-codereview-add-tag' => 'Ajouter de nouvelles balises aux révisions', @@ -3191,6 +3201,7 @@ 'code-author-unlinksuccess' => 'L’ôtor $1 at étâ dèliyê', 'code-author-badtoken' => 'Èrror de sèance pendent l’ègzécucion de l’accion.', 'code-author-total' => 'Soma totâla d’ôtors : $1', + 'code-author-lastcommit' => 'Dèrriére dâta d’èxpèdicion', 'code-browsing-path' => "Parcors de les rèvisions dens '''$1'''", 'code-field-id' => 'Rèvision', 'code-field-author' => 'Ôtor', @@ -3289,6 +3300,7 @@ 'repoadmin-edit-view' => 'Chemin de ViewVC :', 'repoadmin-edit-button' => 'D’acôrd', 'repoadmin-edit-sucess' => 'Lo dèpôt « [[Special:Code/$1|$1]] » at étâ changiê avouéc reusséta.', + 'repoadmin-nav' => 'administracion du dèpôt', 'right-repoadmin' => 'Administrar los dèpôts de code', 'right-codereview-use' => 'Utilisar Special:Code', 'right-codereview-add-tag' => 'Apondre de balises novèles a les rèvisions', @@ -3702,6 +3714,7 @@ 'repoadmin-edit-view' => 'Pfad zue ViewVC:', 'repoadmin-edit-button' => 'In Ornig', 'repoadmin-edit-sucess' => 'S Depot „[[Special:Code/$1|$1]]“ isch mit Erfolg gänderet wore.', + 'repoadmin-nav' => 'Repositoriumsverwaltig', 'right-repoadmin' => 'Code-Depots verwalte', 'right-codereview-use' => 'Special:Code verwände', 'right-codereview-add-tag' => 'Neiji Markierig zue dr Version zuefiege', @@ -4000,6 +4013,7 @@ 'repoadmin-edit-view' => 'Putanja za ViewVC:', 'repoadmin-edit-button' => 'OK', 'repoadmin-edit-sucess' => 'Repozitorij "[[Special:Code/$1|$1]]" je uspješno preinačen.', + 'repoadmin-nav' => 'administracija repozitorija', 'right-repoadmin' => 'Upravljanje kodom repozitorija', 'right-codereview-use' => 'Uporaba Special:Code', 'right-codereview-add-tag' => 'Dodavanje nove oznake za revizije', @@ -6087,6 +6101,7 @@ 'repoadmin-edit-view' => 'വ്യൂവിസി പഥം:', 'repoadmin-edit-button' => 'ശരി', 'repoadmin-edit-sucess' => '"[[Special:Code/$1|$1]]" എന്ന റെപ്പോസിറ്ററി വിജയകരമായി പുതുക്കിയിരിക്കുന്നു.', + 'repoadmin-nav' => 'റെപ്പോസിറ്ററി കാര്യനിർവഹണം', 'right-repoadmin' => 'കോഡ് റെപ്പോസിറ്ററിയുടെ കൈകാര്യം', 'right-codereview-use' => 'Special:Code ഉപയോഗം', 'right-codereview-add-tag' => 'നാൾപ്പതിപ്പുകൾക്ക് പുതിയ റ്റാഗുകൾ ചേർക്കുക', @@ -6792,6 +6807,7 @@ 'repoadmin-edit-view' => 'ViewVC URL', 'repoadmin-edit-button' => 'OK', 'repoadmin-edit-sucess' => 'Database [[Special:Code/$1|$1]] har blitt endret.', + 'repoadmin-nav' => 'repositorieadministrasjon', 'right-repoadmin' => 'Håndtere kodedatabaser', 'right-codereview-use' => 'Bruk av Special:Code', 'right-codereview-add-tag' => 'Legg til nye tagger til versjoner', @@ -7142,7 +7158,7 @@ 'code-authors' => 'autor', 'code-status' => 'stat', 'code-tags' => 'tichëtte', - 'code-authors-text' => "Sota a-i é na lista dj'autor dël depòsit ant l'órdin dël nòm ëd salvatagi. Ij cont dla wiki local a son mostrà antra parèntes. Ij dat a son an cache.", + 'code-authors-text' => "Sota a-i é na lista dj'autor dël depòsit ant l'órdin dël nòm ëd salvatagi. Ij cont dla wiki local a son mostrà antra parèntes. Ij dat a podrìo ven-e da na memòria local.", 'code-author-haslink' => "St'autor-sì a l'é colegà a l'utent wiki $1", 'code-author-orphan' => "St'autor-sì a l'ha pa gnun colegament con un cont wiki", 'code-author-dolink' => "Colega st'autor-sì a n'utent wiki:", @@ -7604,6 +7620,7 @@ 'repoadmin-edit-view' => 'Caminho do ViewVC:', 'repoadmin-edit-button' => 'OK', 'repoadmin-edit-sucess' => 'O repositório "[[Special:Code/$1|$1]]" foi modificado com sucesso.', + 'repoadmin-nav' => 'administração do repositório', 'right-repoadmin' => 'Gerenciar repositórios de código', 'right-codereview-use' => 'Uso de Special:Code', 'right-codereview-add-tag' => 'Adicionar novas etiquetas a revisões', @@ -8776,10 +8793,16 @@ * @author TRYPPN */ $messages['ta'] = array( + 'code-comments' => 'கருத்துரைகள்', 'code-change-removed' => 'நீக்கப்பட்டது:', 'code-change-added' => 'சேர்க்கப்பட்டது:', 'code-old-status' => 'பழைய நிலைமை', 'code-new-status' => 'புதிய நிலைமை', + 'code-statuschanges' => 'நிலையின் மாற்றங்கள்', + 'code-authors' => 'ஆசிரியர்கள்', + 'code-author-name' => 'பயனர் பெயரொன்றை இடுக:', + 'code-field-id' => 'திருத்தம்', + 'code-field-author' => 'ஆசிரியர்', 'code-field-status' => 'நிலைமை', 'code-field-timestamp' => 'தேதி', 'code-field-comments' => 'குறிப்புகள்', @@ -8788,12 +8811,14 @@ 'code-field-select' => 'தேர்வு செய்', 'code-rev-author' => 'ஆசிரியர்:', 'code-rev-date' => 'தேதி:', + 'code-rev-message' => 'கருத்து:', + 'code-rev-rev' => 'திருத்தம்:', 'code-rev-modified-d' => 'நீக்கப்பட்டது', 'code-rev-modified-m' => 'மாற்றப்பட்டுள்ளது', 'code-rev-status' => 'நிலைமை:', 'code-rev-comment-preview' => 'முன்தோற்றம்', 'code-rev-inline-preview' => 'முன்தோற்றம்:', - 'code-rev-diff' => 'வித்தியாசம்', + 'code-rev-diff' => 'வேறுபாடு', 'code-rev-diff-link' => 'வேறுபாடு', 'code-status-new' => 'புதிய', 'code-status-reverted' => 'முன்நிலையாக்கப்பட்டது', @@ -8802,7 +8827,8 @@ 'code-status-verified' => 'சரிபார்க்கப்பட்டது', 'code-status-old' => 'பழைய', 'code-pathsearch-path' => 'வழி:', - 'codereview-reply-link' => 'பதில்', + 'codereview-batch-submit' => 'சமர்ப்பி', + 'codereview-reply-link' => 'பதில் அளி', 'code-stats' => 'புள்ளிவிவரங்கள்', 'repoadmin-new-button' => 'உருவாக்கவும்', 'repoadmin-edit-button' => 'ஆம்', @@ -9643,7 +9669,7 @@ Адреса для подальшого перегляду $5', 'code-stats' => 'статистика', - 'code-stats-header' => 'Статистика репозиторію для $1', + 'code-stats-header' => 'Статистика репозиторія $1', 'code-stats-main' => 'Станом на $1, репозиторій має $2 {{PLURAL:$2|перегляд|перегляди|переглядів}} виконаних [[Special:Code/$3/author|$4 {{PLURAL:$4|автором|авторами}}]].', 'code-stats-status-breakdown' => 'Кількість переглядів на стан', 'code-stats-fixme-breakdown' => 'Розподіл змін з статусом "виправити" по авторам', @@ -9685,9 +9711,11 @@ 'code-prop-changes' => 'Registro del stato e del tagging', 'codereview-desc' => '[[Special:Code|Strumento de revision del codice]] con [[Special:RepoAdmin|suporto par le sotoversioni]]', 'code-no-repo' => 'Nissun deposito configurà!', + 'code-repo-not-found' => "El deposito '''$1''' no l'esiste!", 'code-load-diff' => 'Cargo le difarense…', 'code-notes' => 'note reçenti', 'code-statuschanges' => 'canbiamenti de stato', + 'code-mycommits' => 'i me salvataji', 'code-authors' => 'autori', 'code-status' => 'stati', 'code-tags' => 'tag', @@ -9702,6 +9730,8 @@ 'code-author-link' => 'ligar?', 'code-author-unlink' => 'desligar?', 'code-author-unlinksuccess' => "El colegamento a l'autor $1 el xe stà cavà", + 'code-author-total' => 'Nùmaro total de autori: $1', + 'code-author-lastcommit' => 'Ultima data de salvatajo', 'code-browsing-path' => "Sfojando le revision in '''$1'''", 'code-field-id' => 'Revision', 'code-field-author' => 'Autor', @@ -9738,6 +9768,7 @@ 'code-rev-diff-too-large' => 'Sto diff el xe massa grando par mostrarlo.', 'code-rev-purge-link' => 'netar', 'code-rev-total' => 'Nùmaro total de risultati: $1', + 'code-rev-not-found' => "La revision '''$1''' no la esiste!", 'code-status-new' => 'novo', 'code-status-fixme' => 'da justar', 'code-status-reverted' => 'tirà indrìo', @@ -9748,6 +9779,10 @@ 'code-status-old' => 'vecio', 'code-pathsearch-legend' => 'Serca le version drento sto deposito, in base al percorso', 'code-pathsearch-path' => 'Percorso:', + 'code-pathsearch-filter' => 'Filtro aplicà:', + 'code-revfilter-cr_status' => 'Stato = $1', + 'code-revfilter-cr_author' => 'Autor = $1', + 'code-revfilter-clear' => 'Scansela filtro', 'code-rev-submit' => 'Salva le modìfeghe', 'code-rev-submit-next' => 'Salva e và al prossimo che xe da justar', 'code-batch-status' => 'Cànbia stato:', @@ -9779,6 +9814,10 @@ Ojeto de la modifica: $4', + 'code-stats' => 'statisteghe', + 'code-stats-header' => 'Statìsteghe del deposito $1', + 'code-stats-status-breakdown' => 'Numaro de revisioni par stato', + 'code-stats-count' => 'Numaro de revision', 'repoadmin' => "'Ministrassion dei depositi", 'repoadmin-new-legend' => 'Crea un deposito novo', 'repoadmin-new-label' => 'Nome del deposito:', @@ -9789,6 +9828,7 @@ 'repoadmin-edit-view' => 'Percorso de ViewVC:', 'repoadmin-edit-button' => 'Va ben', 'repoadmin-edit-sucess' => 'El deposito "[[Special:Code/$1|$1]]" el xe stà modificà.', + 'repoadmin-nav' => "'ministrassion del deposito", 'right-repoadmin' => 'Gestir i depositi de codice', 'right-codereview-use' => 'Utilizo de Special:Code', 'right-codereview-add-tag' => 'Zonta tag novi a le revision', Copied: branches/wmf/1.16wmf4/extensions/CodeReview/README (from rev 74821, trunk/extensions/CodeReview/README) =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/README (rev 0) +++ branches/wmf/1.16wmf4/extensions/CodeReview/README 2010-11-06 18:52:46 UTC (rev 76208) @@ -0,0 +1,2 @@ +For information on how to install and use this extension, please see: + http://www.mediawiki.org/wiki/Extension:CodeReview Modified: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -158,6 +158,6 @@ } public function getVersion() { - return __CLASS__ . ': $Id: ApiCodeComments.php 48777 2009-03-25 01:26:54Z aaron $'; + return __CLASS__ . ': $Id$'; } } Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeComments.php ___________________________________________________________________ Added: svn:keywords + Id Modified: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -83,6 +83,6 @@ } public function getVersion() { - return __CLASS__ . ': $Id: ApiCodeDiff.php 48777 2009-03-25 01:26:54Z aaron $'; + return __CLASS__ . ': $Id$'; } } Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeDiff.php ___________________________________________________________________ Added: svn:keywords + Id Modified: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -165,6 +165,6 @@ } public function getVersion() { - return __CLASS__ . ': $Id: ApiCodeComments.php 48777 2009-03-25 01:26:54Z aaron $'; + return __CLASS__ . ': $Id$'; } } Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeRevisions.php ___________________________________________________________________ Added: svn:keywords + Id Modified: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -107,6 +107,6 @@ } public function getVersion() { - return __CLASS__ . ': $Id: ApiCodeUpdate.php 48928 2009-03-27 18:41:20Z catrope $'; + return __CLASS__ . ': $Id$'; } } Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/api/ApiCodeUpdate.php ___________________________________________________________________ Added: svn:keywords + Id Modified: branches/wmf/1.16wmf4/extensions/CodeReview/svnImport.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/svnImport.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/svnImport.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -8,6 +8,7 @@ class SvnImport extends Maintenance { + /* Initialize various stuff to make this a useful command line script */ public function __construct() { parent::__construct(); $this->mDescription = "Import revisions to Code Review from a Subversion repo"; @@ -43,6 +44,11 @@ } } + /* + * Import a repository in the local database. + * @param $repoName String Local name of repository + * @param $start Int Revision to begin the import from (Default: null, means last stored revision); + */ private function importRepo( $repoName, $start = null, $cacheSize = 0 ) { global $wgCodeReviewImportBatchSize; @@ -54,15 +60,22 @@ } $svn = SubversionAdaptor::newFromRepo( $repo->getPath() ); + $this->output( "Using " . get_class($svn). " adaptor\n" ); $lastStoredRev = $repo->getLastStoredRev(); + $this->output( "Last stored revision: $lastStoredRev\n" ); $chunkSize = $wgCodeReviewImportBatchSize; $startTime = microtime( true ); $revCount = 0; $start = ( $start !== null ) ? intval( $start ) : $lastStoredRev + 1; + /* + * FIXME: when importing only a part of a repository, the given path + * might not have been created with revision 1. For example, the + * mediawiki '/trunk/phase3' got created with r1284. + */ if ( $start > ( $lastStoredRev + 1 ) ) { - $this->error( "Invalid starting point r{$start}" ); + $this->error( "Invalid starting point. r{$start} is beyond last stored revision: r" . ($lastStoredRev + 1) ); return; } @@ -89,7 +102,7 @@ } if ( !is_array( $log ) ) { var_dump( $log ); // @TODO: cleanup :) - $this->error( 'wtf', true ); + $this->error( 'Log entry is not an array! See content above.', true ); } foreach ( $log as $data ) { $revCount++; Modified: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeAuthorListView.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeAuthorListView.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeAuthorListView.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -32,11 +32,10 @@ $text .= " ([[$title|$name]])"; } $wgOut->addWikiText( $text ); - - $wgOut->addHTML( "</td><td>{$wgLang->timeanddate( $committer['lastcommit'], true )}</td></tr>" ); + $wgOut->addHTML( "</td><td>{$wgLang->timeanddate( $committer['lastcommit'], true )}</td></tr>" ); } } - $wgOut->addHTML( '</table>' ); + $wgOut->addHTML( '</table>' ); } } Modified: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeReleaseNotes.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeReleaseNotes.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeReleaseNotes.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -27,7 +27,7 @@ $this->showForm(); # Sanity/performance check... $lastRev = $this->mRepo->getLastStoredRev(); - if ( $this->mStartRev < ( $lastRev - 5000 ) ) { + if ( $this->mStartRev < ( $lastRev - 10000 ) ) { global $wgOut; $wgOut->addHtml( wfMsgHtml( 'code-release-badrange' ) ); return; Modified: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionListView.php =================================================================== --- branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionListView.php 2010-11-06 18:52:32 UTC (rev 76207) +++ branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionListView.php 2010-11-06 18:52:46 UTC (rev 76208) @@ -109,7 +109,6 @@ protected function buildBatchInterface( $pager ) { global $wgUser; - $changeInterface = ''; $changeFields = array(); if ( $wgUser->isAllowed( 'codereview-set-status' ) ) { @@ -322,7 +321,6 @@ case 'cr_message': return $this->mView->messageFragment( $value ); case 'cr_timestamp': - global $wgLang; return $wgLang->timeanddate( $value, true ); case 'comments': if ( $value ) { Property changes on: branches/wmf/1.16wmf4/extensions/CodeReview/ui/CodeRevisionView.php ___________________________________________________________________ Modified: svn:mergeinfo - /trunk/extensions/CodeReview/ui/CodeRevisionView.php:54189-54190,62820-74784,74985,75235 + /trunk/extensions/CodeReview/ui/CodeRevisionView.php:54189-54190,62820-74821,74985,75235 _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs