http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90221

Revision: 90221
Author:   brion
Date:     2011-06-16 18:49:52 +0000 (Thu, 16 Jun 2011)
Log Message:
-----------
* (bug 29424) Fix for underscore form and other non-normalized usernames on 
Special:GlobalUserRights (CentralAuth version)

Names weren't being validated at all before being sent off to CentralAuthUser, 
which itself doesn't seem to do any validation.
Running through User::getCanonicalName() to clean it up, same as is used for 
User::newFromName().

Modified Paths:
--------------
    trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php

Modified: trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php
===================================================================
--- trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php    
2011-06-16 17:58:51 UTC (rev 90220)
+++ trunk/extensions/CentralAuth/CentralAuthGroupMembershipProxy.php    
2011-06-16 18:49:52 UTC (rev 90221)
@@ -19,6 +19,7 @@
        }
 
        public static function newFromName( $name ) {
+               $name = User::getCanonicalName( $name );
                $globalUser = new CentralAuthUser( $name );
                return $globalUser->exists() ? new 
CentralAuthGroupMembershipProxy( $globalUser ) : null;
        }


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to